Uh oh!
There was an error while loading. Please reload this page.
deps(knip): configuring knip and removing dead code - #225
Conversation
No actionable issues found. See task
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Pushed d4df00b6e on What changed:
Validation:
Visual proof: not applicable for this change because it only updates backend/tooling test coverage. CI is rerunning now on |
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Uh oh!
There was an error while loading. Please reload this page.
3f96d01 to
5b6b41eCompareUh oh!
There was an error while loading. Please reload this page.
I see some merge conflicts here. Working on them now... |
I detected merge conflicts but could not start a task to address them. |
3 similar comments
I detected merge conflicts but could not start a task to address them. |
I detected merge conflicts but could not start a task to address them. |
I detected merge conflicts but could not start a task to address them. |
This PR has merge conflicts that need to be resolved. |
I detected merge conflicts but could not start a task to address them. |
2 similar comments
I detected merge conflicts but could not start a task to address them. |
I detected merge conflicts but could not start a task to address them. |
This PR has merge conflicts that need to be resolved. |
1 similar comment
This PR has merge conflicts that need to be resolved. |
This PR has merge conflicts that need to be resolved. |
I detected merge conflicts but could not start a task to address them. |
2 similar comments
I detected merge conflicts but could not start a task to address them. |
I detected merge conflicts but could not start a task to address them. |
This PR has merge conflicts that need to be resolved. |
I detected merge conflicts but could not start a task to address them. |
1 similar comment
I detected merge conflicts but could not start a task to address them. |
This PR has merge conflicts that need to be resolved. |
I detected merge conflicts but could not start a task to address them. |
This PR has merge conflicts that need to be resolved. |
1 similar comment
This PR has merge conflicts that need to be resolved. |
I detected merge conflicts but could not start a task to address them. |
3 similar comments
I detected merge conflicts but could not start a task to address them. |
I detected merge conflicts but could not start a task to address them. |
I detected merge conflicts but could not start a task to address them. |
This PR has merge conflicts that need to be resolved. |
I detected merge conflicts but could not start a task to address them. |
This PR has merge conflicts that need to be resolved. |
I detected merge conflicts but could not start a task to address them. |
8a98d56 to
5053febCompare
edelauna
left a comment
There was a problem hiding this comment.
Reusing PR to fix knip config - will address findings in a separate PR
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Elliott de Launay <edelauna@gmail.com>
Related to: #519
What problem this solves
Knip was only configured to detect unused files and dependencies. This extends the configuration to also catch unused exports, enum members, duplicate exports, and types — surfacing dead code that was previously invisible to static analysis.
What changed
Knip configuration (
knip.json)rulesforexports,types,enumMembers,nsExports,nsTypes, andduplicatesatwarnlevel (non-blocking, exit 0)classMembers: off(too noisy for the current codebase)ignoreforeslint.config.mjsandscripts/**inapps/clito fix graph traversal after the sdk directory was removedDead code removed
apps/cli/src/agent/extension-host.ts: removed deaduser: nullfield fromExtensionHostOptionsinterface and all callers (App.tsx,useExtensionHost.ts,Header.tsx,list.ts,run.ts,extension-host.test.ts)apps/cli/scripts/build.shand.github/workflows/cli-release.yml: removed stale@trpc/clientandsuperjsonentries from release package.json construction (dependencies were already removed)packages/types/src/task.ts: deletedTaskStatus.Noneenum member (zero callers)webview-ui/src/components/ui/select-dropdown.tsx: deletedDropdownOptionType.ITEMenum member (never referenced)src/core/tools/EditTool.ts: deletedsearchAndReplaceToolaliassrc/core/tools/SearchAndReplaceTool.ts: deleted (re-exported only the now-deleted alias)src/core/tools/__tests__/searchAndReplaceTool.spec.ts: deleted (tested the now-deleted alias)src/api/providers/lm-studio.ts: deleted privategetLmStudioModelsfunction (never called, shadowed by a same-named local function inuseLmStudioModels.ts)packages/build/src/types.ts: deleted 5 unusedtype X = z.infer<typeof xSchema>aliasespackages/vscode-shim/src/types.ts: removed 4 unexported unused interfaces (TextDocument,WorkspaceFolder,WorkspaceConfiguration,CancellationToken)Formatting
git diff --check