Uh oh!
There was an error while loading. Please reload this page.
[Fix] Recursive list_files omits nested files in temp workspaces - #91
Conversation
1 issue outstanding. Action required. See task
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
f4eef5e to
9f39044CompareI see some merge conflicts here. Working on them now... |
9f39044 to
61e6fe5CompareI see some merge conflicts here. Working on them now... |
61e6fe5 to
653e227CompareI see some merge conflicts here. Working on them now... |
Fixed the remaining Windows CI follow-up in 893d29b81. The last failing assertion in Validation: |
Uh oh!
There was an error while loading. Please reload this page.
8cc02ae to
eb95c4eCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
49dd725 to
0f30e86CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
17bce1c to
26ff2c0Compare
edelauna
left a comment
There was a problem hiding this comment.
Only spec files updated to increase coverage
Uh oh!
There was an error while loading. Please reload this page.
What problem this solves
Fixes an issue where users running recursive
list_filesin temp-backed workspaces could get only directory entries and miss nested files. It also keeps the newly unskipped read-only VS Code e2e coverage and the focused unit regression aligned with real prompts, real tool-output validation, and cross-platform CI behavior so that regression stays covered on both Unix and Windows runners.Why this change was made
The stricter replay validation exposed that recursive
list_fileswas invoking ripgrep on an absolute/tmp/...path, so the existing ignore glob filtered out real file results. This change runs ripgrep from the target directory, adds a focused regression test for that ancestor-path case, updates the read-only replay fixtures and tests to use natural-language prompts plus representativelist_filesandsearch_filesoutput checks, and aligns the new unit assertions with the implementation's resolved paths on Windows.User impact
Recursive
list_filesnow returns nested files correctly in temp-backed workspaces instead of stopping at directories, and the read-only VS Code e2e plus unit coverage now keeps that behavior and the relatedsearch_filesworkflows covered in replay, real-endpoint runs, and Windows CI.Related PRs