Better token classification. Moved required option/positional checks.… - #3
Merged
Conversation
… Handle unknown options and excess positionals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… Handle unknown options and excess positionals
Summary
Fixes the parser assigning a flag's value to a positional argument. The parser now classifies tokens once as a positional, option, or unknown. Also errors on unknown options and excess positionals, which were being silently ignored.
Changes
parse_intoandmatch_optionhelpertests/test_positionals.cppChecklist
tests/CHANGELOG.mdupdated under[Unreleased]examples/(if user-visible)