Skip to content

tests: Assert connection error code rather than message - #1023

Merged
lmars merged 1 commit into
mainfrom
test-no-error-message
Jul 24, 2024
Merged

tests: Assert connection error code rather than message#1023
lmars merged 1 commit into
mainfrom
test-no-error-message

Conversation

@lmars

Copy link
Copy Markdown
Member

The error messages are subject to change, but the codes are not, so assert the code instead.

The error messages are subject to change, but the codes are not, so
assert the code instead.
Signed-off-by: Lewis Marshall <lewis.marshall@ably.com>

@ttypicttypic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@lmars@ttypic