Skip to content

Support for encryption of shared preferences - #681

Merged
QuintinWillison merged 8 commits into
mainfrom
593-support-for-encryption-of-shared-preferences
Aug 5, 2021
Merged

Support for encryption of shared preferences#681
QuintinWillison merged 8 commits into
mainfrom
593-support-for-encryption-of-shared-preferences

Conversation

@martin-morek

@martin-morekmartin-morek commented Jul 2, 2021

Copy link
Copy Markdown
Contributor
  • Fixes593
  • Default SharedPreferences could be replaced with custom Storage implementation, ClientOptions allows to inject custom object. If nothing is injected current behaviour using SharedPreferences is used so no need to do any changes to keep current functionality.

@martin-morek
martin-morek marked this pull request as ready for review July 6, 2021 12:35
sacOO7
sacOO7 reviewed Jul 7, 2021
View reviewed changes
Comment threadlib/src/main/java/io/ably/lib/push/Storage.java Outdated
sacOO7
sacOO7 reviewed Jul 7, 2021
View reviewed changes
Comment threadandroid/src/main/java/io/ably/lib/push/SharedPreferenceStorage.java Outdated
sacOO7
sacOO7 reviewed Jul 7, 2021
View reviewed changes
Comment threadlib/src/main/java/io/ably/lib/push/Storage.java Outdated
sacOO7
sacOO7 reviewed Jul 7, 2021
View reviewed changes
Comment threadlib/src/main/java/io/ably/lib/push/Storage.java
@jamienewcomb

jamienewcomb commented Jul 20, 2021

Copy link
Copy Markdown
Member

@sacOO7 are you happy with the changes?

@QuintinWillisonQuintinWillison mentioned this pull request Oct 3, 2022
Open
QuintinWillison
QuintinWillison suggested changes Jul 27, 2021
View reviewed changes

@QuintinWillisonQuintinWillison left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tweaks, please.

Comment threadandroid/src/main/java/io/ably/lib/push/SharedPreferenceStorage.java
Comment threadlib/src/main/java/io/ably/lib/push/Storage.java
Comment threadlib/src/main/java/io/ably/lib/push/Storage.java Outdated
Comment threadlib/src/main/java/io/ably/lib/types/ClientOptions.java Outdated
Comment threadlib/src/main/java/io/ably/lib/types/ClientOptions.java Outdated
@QuintinWillison
QuintinWillison merged commit 3e6ff70 into mainAug 5, 2021
@QuintinWillison
QuintinWillison deleted the 593-support-for-encryption-of-shared-preferences branch August 5, 2021 08:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sacOO7sacOO7sacOO7 approved these changes
+1 more reviewer
@QuintinWillisonQuintinWillisonQuintinWillison approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for encryption of shared preferences

4 participants

@martin-morek@jamienewcomb@QuintinWillison@sacOO7