Uh oh!
There was an error while loading. Please reload this page.
Revert to protocol 1.1 - #858
Merged
Merged
Conversation
QuintinWillison
approved these changes
Nov 21, 2022
davyskiba
approved these changes
Nov 22, 2022
davyskiba
left a comment
Contributor
There was a problem hiding this comment.
changes seem reasonable, but I'm lacking knowledge to confidently say that this is a complete change 😬
ikbalkaya
approved these changes
Nov 22, 2022
This was referenced Nov 23, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will be reverting to protocol 1.1 in order to quick-fix an urgent issue with automatic presence re-enter. The protocol will be bumped to 1.2 again once the presence issue is fixed on the client side.
This PR aims to revert the work done in #591