Skip to content

Connection serial tests - #984

Merged
sacOO7 merged 25 commits into
feature/no-connection-serialfrom
fix/no-connection-serial-tests
Feb 6, 2024
Merged

Connection serial tests#984
sacOO7 merged 25 commits into
feature/no-connection-serialfrom
fix/no-connection-serial-tests

Conversation

@sacOO7

@sacOO7sacOO7 commented Dec 20, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Fixed failing tests for no-connection-serial PR

@github-actions
github-actionsBottemporarily deployed to staging/pull/984/features December 20, 2023 13:29 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/javadoc December 20, 2023 13:30 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/features January 8, 2024 13:08 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/javadoc January 8, 2024 13:09 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/features January 23, 2024 07:17 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/javadoc January 23, 2024 07:18 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/features January 23, 2024 13:34 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/javadoc January 23, 2024 13:34 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/features January 24, 2024 12:38 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/javadoc January 24, 2024 12:39 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/features January 25, 2024 12:33 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/javadoc January 25, 2024 12:34 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/features January 26, 2024 05:47 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/javadoc January 26, 2024 05:48 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/features January 26, 2024 08:04 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/javadoc January 26, 2024 08:05 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/features January 26, 2024 12:03 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/javadoc January 26, 2024 12:04 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/features January 26, 2024 12:05 Inactive
@AndyTWF

AndyTWF commented Jan 31, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Can we get a description of the key changes / issues fixed in the PR, please :)

@sacOO7

sacOO7 commented Jan 31, 2024

Copy link
Copy Markdown
ContributorAuthor

Can we get a description of the key changes / issues fixed in the PR, please :)

updated!

@github-actions
github-actionsBottemporarily deployed to staging/pull/984/features January 31, 2024 10:35 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/javadoc January 31, 2024 10:36 Inactive
sacOO7
sacOO7 commented Jan 31, 2024
View reviewed changes
Comment threadlib/src/test/java/io/ably/lib/test/realtime/RealtimeResumeTest.java
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/features January 31, 2024 12:15 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/javadoc January 31, 2024 12:16 Inactive
@sacOO7
sacOO7force-pushed the fix/no-connection-serial-tests branch from bac486e to 2436f67CompareJanuary 31, 2024 12:21
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/features January 31, 2024 12:21 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/javadoc January 31, 2024 12:22 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/features January 31, 2024 13:07 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/javadoc January 31, 2024 13:08 Inactive
@sacOO7
sacOO7force-pushed the fix/no-connection-serial-tests branch from 6f15af0 to e791f8fCompareJanuary 31, 2024 13:26
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/features January 31, 2024 13:26 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/javadoc January 31, 2024 13:27 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/features February 4, 2024 14:44 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/javadoc February 4, 2024 14:45 Inactive
@sacOO7
sacOO7force-pushed the fix/no-connection-serial-tests branch from 1291486 to 68a0944CompareFebruary 4, 2024 14:46
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/features February 4, 2024 14:46 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/984/javadoc February 4, 2024 14:47 Inactive
ttypic
ttypic approved these changes Feb 5, 2024
View reviewed changes

@ttypicttypic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Comment threadlib/src/test/java/io/ably/lib/test/common/Helpers.java
Comment threadlib/src/test/java/io/ably/lib/test/realtime/RealtimeResumeTest.java
@sacOO7
sacOO7 merged commit ada8758 into feature/no-connection-serialFeb 6, 2024
@sacOO7
sacOO7 deleted the fix/no-connection-serial-tests branch February 6, 2024 13:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttypicttypicttypic approved these changes
@AndyTWFAndyTWFAwaiting requested review from AndyTWF

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sacOO7@AndyTWF@ttypic