Skip to content

Support latest python versions - #547

Merged
sacOO7 merged 10 commits into
mainfrom
feature/support-3.1x
Jan 18, 2024
Merged

Support latest python versions#547
sacOO7 merged 10 commits into
mainfrom
feature/support-3.1x

Conversation

@sacOO7

@sacOO7sacOO7 commented Jan 16, 2024

Copy link
Copy Markdown
Contributor

@github-actions
github-actionsBottemporarily deployed to staging/pull/547/features January 16, 2024 14:38 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/547/features January 17, 2024 08:17 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/547/features January 17, 2024 09:21 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/547/features January 17, 2024 09:40 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/547/features January 17, 2024 09:57 Inactive
@sacOO7
sacOO7force-pushed the feature/support-3.1x branch from f4cbaef to da827acCompareJanuary 17, 2024 10:01
@github-actions
github-actionsBottemporarily deployed to staging/pull/547/features January 17, 2024 10:01 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/547/features January 17, 2024 11:09 Inactive
@sacOO7

sacOO7 commented Jan 17, 2024

Copy link
Copy Markdown
ContributorAuthor

Need to check for flake8 error when used with python-3.12

@sacOO7
sacOO7 marked this pull request as ready for review January 17, 2024 11:20
ttypic
ttypic approved these changes Jan 17, 2024
View reviewed changes

@ttypicttypic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

ttypic
ttypic reviewed Jan 17, 2024
View reviewed changes
Comment thread.github/workflows/check.yml Outdated
@github-actions
github-actionsBottemporarily deployed to staging/pull/547/features January 17, 2024 13:08 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/547/features January 17, 2024 13:21 Inactive
owenpearson
owenpearson reviewed Jan 17, 2024
View reviewed changes

@owenpearsonowenpearson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve once the CI is passing, but just wanted to say: if linting across every python version is a problem then we should just move the flake8 step to its own workflow and run it on a single version of python - we don't really need to run it on every version.

@sacOO7

sacOO7 commented Jan 18, 2024

Copy link
Copy Markdown
ContributorAuthor

I'll approve once the CI is passing, but just wanted to say: if linting across every python version is a problem then we should just move the flake8 step to its own workflow and run it on a single version of python - we don't really need to run it on every version.

I agree to this 👍

@github-actions
github-actionsBottemporarily deployed to staging/pull/547/features January 18, 2024 06:38 Inactive
@sacOO7
sacOO7force-pushed the feature/support-3.1x branch from e0777af to 31f83fbCompareJanuary 18, 2024 06:39
@github-actions
github-actionsBottemporarily deployed to staging/pull/547/features January 18, 2024 06:40 Inactive
@sacOO7sacOO7 mentioned this pull request Jan 18, 2024
Open
@sacOO7
sacOO7 merged commit 1a99f00 into mainJan 18, 2024
@sacOO7
sacOO7 deleted the feature/support-3.1x branch January 18, 2024 08:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttypicttypicttypic approved these changes
@owenpearsonowenpearsonowenpearson left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for python 3.12

3 participants

@sacOO7@ttypic@owenpearson