Implement no-connection-serial · Pull Request #387 · ably/ably-ruby

ghost · 2022-10-10T12:10:48Z

Resolves#378

Affected REST tests:

./spec/acceptance/rest/push_admin_spec.rb

Affected realtime tests:

./spec/acceptance/realtime/presence_spec.rb
./spec/acceptance/realtime/channel_spec.rb
./spec/acceptance/realtime/message_spec.rb
./spec/acceptance/realtime/connection_failures_spec.rb
./spec/acceptance/realtime/connection_spec.rb
./spec/acceptance/realtime/push_admin_spec.rb

… state.

…nnel_serial.

…y method. Remove update_connection_serial method.

…connection serial.

…failed states. Set channel_serial on sync, presence and message states.

…erial

… method.

…port.

Łukasz Śliwa added 7 commits October 10, 2022 13:56

Removed connection_serial attribute and related methods. Add ACTIVATE…
6910763
… state.

Add channel_serial attribute to ChannelProperties
4055a5d

Set channel_serial when channel state changes to attached. Nilify cha…
3bab22b
…nnel_serial.

Remove update_connection_recovery_info frmo incoming_message_dispatcher
b2976dd

Update RECOVER_REGEX and remove connection.serial. Update recovery_ke…
5da7f14
…y method. Remove update_connection_serial method.

Add recovery_key method to connection_manager. Remove related to the …
723f45a
…connection serial.

Change protocol version
1735484

github-actionsBot temporarily deployed to staging/pull/387/docs October 10, 2022 12:11 Inactive

ghost self-assigned this Oct 10, 2022

Nullify channel_properties.channel_serial on detached, suspended and …
2091d99
…failed states. Set channel_serial on sync, presence and message states.

github-actionsBot temporarily deployed to staging/pull/387/docs October 10, 2022 12:27 Inactive

Set channel_serial on attached, message and presence states
239b4cb

github-actionsBot temporarily deployed to staging/pull/387/docs October 10, 2022 12:29 Inactive

Łukasz Śliwa added 4 commits October 17, 2022 12:54

Add recovery_serials and serials to Ably::Realtime::Client
788c6d3

Update docstring Ably::Realtime::Channel::ChannelProperties#channel_s…
94b8e9e
…erial

Remove RECOVERY_REGEX. Update Ably::Realtime::Connection#recovery_key…
4507293
… method.

Update connection manager.
e7a89e5

github-actionsBot temporarily deployed to staging/pull/387/docs October 17, 2022 10:58 Inactive

Generate device_secret if not present. Fix tests.
f19e7ec

github-actionsBot temporarily deployed to staging/pull/387/docs October 24, 2022 14:36 Inactive

Rename getRecoveryKey->createRecoveryKey per updated spec
19a7191

github-actionsBot temporarily deployed to staging/pull/387/docs October 31, 2022 18:58 Inactive

Łukasz Śliwa added 8 commits November 7, 2022 13:06

Remove missing serial exception
d80ee1b

Make channel_serial accessible to read/write
4d85dd8

Update channel_serial on specific action
d71f840

Fix recovery key check
5c7ebd9

Set channel_serial
34f52be

Fix Ably::Realtime::Connection#recovery_key method
751eab5

Stop checking if protocol message is valid/invalid in websocket trans…
ce02a76
…port.

Fix spec/acceptance/realtime/channel_spec.rb
6d43cc6

Łukasz Śliwa added 7 commits November 7, 2022 13:29

Fix spec/acceptance/realtime/presence_spec.rb
977849e

Fix spec/acceptance/rest/client_spec.rb
129db4b

Fix spec/acceptance/rest/message_spec.rb
5cf0acd

Fix spec/unit/models/protocol_message_spec.rb
af5c0b4

Fix spec/unit/realtime/connection_spec.rb
9e12f7a

Fix spec/unit/realtime/incoming_message_dispatcher_spec.rb
97e56c4

Merge branch 'issue-378' of github.com:ably/ably-ruby into issue-378
f8032b0

github-actionsBot temporarily deployed to staging/pull/387/docs November 7, 2022 12:37 Inactive

Fix spec/unit/models/device_details_spec.rb
7a49634

github-actionsBot temporarily deployed to staging/pull/387/docs November 7, 2022 12:53 Inactive

Łukasz Śliwa added 2 commits November 8, 2022 12:02

Setting channel_serial for non NilChannel objects on ACTION.Attached
a9f705a

Fix missing msg_serial exception
77b0bfc

github-actionsBot temporarily deployed to staging/pull/387/docs November 8, 2022 11:25 Inactive

Rename recovery_key to create_recovery_key
090611d

github-actionsBot temporarily deployed to staging/pull/387/docs November 8, 2022 11:27 Inactive

Łukasz Śliwa added 5 commits November 28, 2022 17:10

Remove msg_serial validation from ProtocolMessage
c64e25a

Checking if a connection is resumable
45d9a97

Fix spec/acceptance/realtime/connection_failures_spec.rb
e9b811d

Fix spec/acceptance/realtime/connection_spec.rb
634bc96

Fix spec/acceptance/realtime/message_spec.rb
cb6ec2a

github-actionsBot temporarily deployed to staging/pull/387/docs November 28, 2022 16:13 Inactive

QuintinWillison suggested changes Nov 28, 2022
View reviewed changes

Comment threadlib/ably/version.rb Outdated

Fix failed unit tests
76ae696

github-actionsBot temporarily deployed to staging/pull/387/docs November 29, 2022 16:35 Inactive

Fix protocol version
422fc81

github-actionsBotdeployed to staging/pull/387/docs December 5, 2022 17:39 View deployment

ghost assigned stmoreau and unassigned ghostDec 6, 2022

stmoreau removed their assignment Dec 6, 2022

ghost closed this Dec 6, 2022

This pull request was closed.

Navigation Menu

Uh oh!

Implement no-connection-serial - #387

Implement no-connection-serial#387
ghost wants to merge 44 commits into
mainfrom
issue-378

ghost commented Oct 10, 2022•
edited by ghost
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ghost commented Oct 10, 2022• edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

ghost commented Oct 10, 2022•
edited by ghost
Loading