Skip to content

[ECO-4767] Fix server certificate validation for HTTP in Realtime - #397

Merged
lawrence-forooghian merged 1 commit into
mainfrom
396-internet-up-tls-error
May 15, 2024
Merged

[ECO-4767] Fix server certificate validation for HTTP in Realtime#397
lawrence-forooghian merged 1 commit into
mainfrom
396-internet-up-tls-error

Conversation

@lawrence-forooghian

@lawrence-forooghianlawrence-forooghian commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

Resolves#396.

(The tests pass when combined with @sacOO7’s WIP test fixes from #391; see #403.)

@lawrence-forooghian
lawrence-forooghian changed the base branch from main to fix/testsApril 24, 2024 20:26
@github-actions
github-actionsBottemporarily deployed to staging/pull/397/features April 24, 2024 20:26 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/397/docs April 24, 2024 20:27 Inactive
@lawrence-forooghian
lawrence-forooghian changed the base branch from fix/tests to mainApril 25, 2024 18:20
@github-actions
github-actionsBottemporarily deployed to staging/pull/397/features April 25, 2024 18:20 Inactive
@github-actions
github-actionsBottemporarily deployed to staging/pull/397/docs April 25, 2024 18:20 Inactive
See ably-forks/em-http-request#2.
This fixes the internet-up check and hence the fallback hosts mechanism.
Resolves#396.
@lawrence-forooghian
lawrence-forooghianforce-pushed the 396-internet-up-tls-error branch from 26d30e4 to 48d4d9aCompareMay 15, 2024 12:14
@lawrence-forooghianlawrence-forooghian changed the title [WIP, ECO-4767] Try a fix for TLS verification error[WIP, ECO-4767] Fix server certificate validation for HTTP in RealtimeMay 15, 2024
@lawrence-forooghianlawrence-forooghian changed the title [WIP, ECO-4767] Fix server certificate validation for HTTP in Realtime[ECO-4767] Fix server certificate validation for HTTP in RealtimeMay 15, 2024
@lawrence-forooghian
lawrence-forooghian marked this pull request as ready for review May 15, 2024 12:51

@ttypicttypic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lawrence-forooghian
lawrence-forooghian deleted the 396-internet-up-tls-error branch May 15, 2024 16:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Invalid server certificate error for internet-up endpoint

2 participants

@lawrence-forooghian@ttypic