Uh oh!
There was an error while loading. Please reload this page.
[ECO-4686] Implement internal presence - #405
Closed
sacOO7 wants to merge 6 commits into
Closed
Conversation
Removed unnecessary client initiated sync defined using resume_sync method.
sacOO7
commented
Jun 6, 2024
ContributorAuthor
Closing in favor of #410 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit summary
:in_syncenum to:sync_completed, since:in_syncis a very confusing term and doesn't go as per spec.resume_sync_proccode that does client initiated sync when channel attaches withhas_presenceflag. This doesn't go as per spec.on_attachmethod topresence_managerthathas_presenceflagon_attachmethod is called.enter_client_with_idmethod to presence that enters local members withid. Earlier local members were entered at the end of the sync and didn't support entering members with given id.