Uh oh!
There was an error while loading. Please reload this page.
rest/channel_spec: fix test checking error messages - #422
Merged
Conversation
Replace error message checks with error code checks. Error messages are not guaranteed to be consistent across versions/systems but the error codes are.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Zariel
commented
Jul 3, 2024
ContributorAuthor
@sacOO7 tests now passing |
jamienewcomb
commented
Jul 4, 2024
Member
@sacOO7 can you approve and merge this if you are happy please |
sacOO7
commented
Jul 4, 2024
Contributor
@Zariel I assume changes are fixed on the sandbox and will not break at client side going forward right? |
sacOO7
reviewed
Jul 4, 2024
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace error message checks with error code checks. Error messages are not guaranteed to be consistent across versions/systems but the error codes are.