Skip to content
This repository was archived by the owner on Aug 10, 2026. It is now read-only.

Add clientId to filter object - #1499

Merged
tbedford merged 3 commits into
mainfrom
add-clientid-to-filter-object
Jul 22, 2022
Merged

Add clientId to filter object#1499
tbedford merged 3 commits into
mainfrom
add-clientid-to-filter-object

Conversation

@Peter-Maguire

@Peter-MaguirePeter-Maguire commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

NOTE TO REVIEWERS - please do not review PRs in the DRAFT state, as the PR may change substantially before it is ready to review. Thanks.

Description

Updates the subscription filter object to contain filtering by client ID

Review

Instructions on how to review the PR.

@kennethkalmer
kennethkalmer temporarily deployed to ably-docs-add-clientid--qcvftl July 21, 2022 11:15 Inactive
@Peter-MaguirePeter-Maguire self-assigned this Jul 21, 2022
@Peter-Maguire
Peter-Maguire marked this pull request as ready for review July 21, 2022 11:17
Comment threadcontent/client-lib-development-guide/features.textile Outdated
Co-authored-by: Lewis Marshall <lewis@lmars.net>
@kennethkalmer
kennethkalmer temporarily deployed to ably-docs-add-clientid--qcvftl July 21, 2022 13:04 Inactive
@Peter-Maguire
Peter-Maguire requested a review from lmarsJuly 21, 2022 14:24
@tbedford
tbedford merged commit edab6b2 into mainJul 22, 2022
@tbedford
tbedford deleted the add-clientid-to-filter-object branch July 22, 2022 12:01
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Peter-Maguire@lmars@Jmgr@owenpearson@kennethkalmer@tbedford