Uh oh!
There was an error while loading. Please reload this page.
[WEB-3950] Simplified docs routing, port page content from YAML to JSON - #2383
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis pull request makes widespread documentation updates across numerous files. Nearly all URL references––whether in redirect paths, inline hyperlinks, or reference links––have been changed to include a Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File ( |
ed97940 to
cc77806Comparedfb96f0 to
481033cCompare481033c to
a830666Comparea830666 to
0443772Compare0443772 to
1478e0cCompare1368333 to
497a41fComparebb08d1a to
f3cf6b0Compared2aa49e to
b386ccbCompare497a41f to
5e9dd03Compare98236b7 to
d37f16aCompare5e9dd03 to
f9ef027Compare4567470 to
dce810aCompare| expect(__PATH_PREFIX__).toBe('/docs'); | ||
| const { getByTestId } = render(<StaticImage src="/images/example.png" />); | ||
| const { getByTestId } = render(<StaticImage src={'/docs/images/example.png'} />); |
There was a problem hiding this comment.
@jamiehenson I think these should not actually have changed and they are hiding an issue that we see as broken images on the homepage.
The src on the homepage for LiveSync is /docs/static/1740413963000127948506/bf86f/livesync.png but on disk the asset is at public/static/1740413963000127948506/bf86f/livesync.png, so no /docs in the path.
When we deploy to production the value of ASSET_PREFIX kicks in and the src will be https://docs.ably.com/static/1..../livesync.png, solving the routing issue through the website.
dce810a to
7021f8dCompare7021f8d to
afafbe4Compareafafbe4 to
5172bf8Comparejamiehenson
commented
Feb 25, 2025
Alright @kennethkalmer I think I've got the right end of it this time - I've also taken the opportunity to convert a few gatsby config files to TS. This is in the third commit, the only logical difference is the removal of I've also updated a few more textile replacements that were missed (relying on regex this time instead of bots), and undone the StaticImage change as mentioned above. Review link here: https://ably-docs-web-3950-norm-xg6o5u.herokuapp.com/docs |
kennethkalmer
commented
Feb 25, 2025
@jamiehenson initial impressions look good! I'm gonna rebuild the review app with the |
m-hulbert
left a comment
There was a problem hiding this comment.
Checked as many links as I could manually and using search. Only came up with the one that I've commented on 👌
Uh oh!
There was an error while loading. Please reload this page.
5172bf8 to
fe08395Comparefe08395 to
d408672Compare
kennethkalmer
left a comment
There was a problem hiding this comment.
After switching the ASSET_PREFIX things still worked as expected on the review app 🎉 .
I think we're good to go, but keep an eye on ContentKing for alerts after this goes live
jamiehenson
commented
Feb 25, 2025
Sweet, will kick this off tomorrow and keep watch 🏰 |
d408672 to
4ecd317Compare
There's a lot of file bluster in this PR but the purpose is quite simple. It does three things:
The result is a lot more simplicity around page routing - links are as they are, there's no more conditional "other" logic when comparing to the main site.
Review site: https://ably-docs-web-3950-norm-xg6o5u.herokuapp.com/docs
Word of bot
This pull request includes various updates to documentation links and configuration files. The main changes involve updating URLs to ensure consistency and accuracy, as well as removing redundant configurations.
Documentation Updates:
/docsprefix for better organization and consistency. [1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17]Configuration Changes:
nodeorb version in.circleci/config.ymlfrom5.2.0to5.3.0.nginxrewrite rules for/docsinconfig/nginx.conf.erb.Testing and Cleanup:
nginx/docsrewriting in the CircleCI configuration.Summary by CodeRabbit