Uh oh!
There was an error while loading. Please reload this page.
Live objects: Add REST API docs - #2490
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File ( |
0acd63d to
c585d8fComparea9b4071 to
6d37df9Comparec585d8f to
4f2c343Compare
VeskeR
left a comment
There was a problem hiding this comment.
Posting some review comments I had while updating the REST API on the client.
Apologies if I jumped the gun on any of them - I realize this PR is still in draft.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| "operation": "MAP_CREATE", | ||
| "data": { | ||
| "myMapKey": {"data": {"string": "myMapValue"}}, | ||
| "myOtherKey": {"data": {"boolean": true}} |
There was a problem hiding this comment.
what was the reasoning to make the map create operation explicitly state the type of the value for a key:{"string": "myMapValue"}, {"boolean": true},
as opposed to a bit simpler previous format:{"value": "myMapValue"}, {"value": true} and to disambiguate objectIds: {"objectId": "counter:Nz1ZiNjqsDfkDjA61xarinqpWsqEGAAw2mzWWtvX2b8@1742481614000"} ?
the latter is slightly easier to use as it's just always "value", unless it's a reference to another object.
is this mainly to maintain parity with the data values returned in the List API responses?
{ "data": { "number" : 4 }}
{ "data": { "string" : "Ably Pub/Sub" }}
{ "data": { "boolean" : true }}
{ "data": { "bytes": "TGl2ZU9iamVjdHMgaXMgYXdlc29tZQo=", "encoding": "base64" }}
{ "data": { "objectId": "counter:Nz1ZiNjqsDfkDjA61xarinqpWsqEGAAw2mzWWtvX2b8@1742481614000" }}Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
cfc1048 to
f207d5dCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
f207d5d to
9992e40Compare
VeskeR
left a comment
There was a problem hiding this comment.
LGTM, one last minor comment to remove the use of "state"
Uh oh!
There was an error while loading. Please reload this page.
Add new page in the "API References" part of the product docs which details the REST APIs available for interacting with live objects.
9992e40 to
fab36afCompare
Description
Add new page in the "API References" part of the product docs which details the REST APIs available for interacting with live objects.
Checklist