Uh oh!
There was an error while loading. Please reload this page.
Fixed issue where pub-sub-occupancy channel name is hard coded - #2572
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File ( |
Uh oh!
There was an error while loading. Please reload this page.
| import './styles/styles.css'; | ||
| const urlParams = new URLSearchParams(typeof window !== 'undefined' ? window.location.search : ''); | ||
| const channelName = urlParams.get('name') || 'pub-sub-occupancy'; |
There was a problem hiding this comment.
Does this work okay? Usually you'd access this sort of stuff inside a useEffect inside the component that runs on mount (i.e. with a dependency array of []) - that's the Reacty way. But given the simplicity and clientside nature of the app, might be alright.
a12e5fa to
a6561c4Compare2ce7c3a to
76f7c01CompareGregHolmes
commented
May 7, 2025
@jamiehenson@kennethkalmer when you have a moment could you check over this again please? |
76f7c01 to
c40ce77Comparec40ce77 to
98e0549Compare98e0549 to
9106ebfCompare
The pub-sub-occupancy examples for both javascript and react were hardcoding the channel name. This PR fixes that.