Skip to content
This repository was archived by the owner on Aug 10, 2026. It is now read-only.

Updated client lib spec to v1.2 - #870

Merged
tomczoink merged 2 commits into
masterfrom
1.2-spec
Apr 16, 2020
Merged

Updated client lib spec to v1.2#870
tomczoink merged 2 commits into
masterfrom
1.2-spec

Conversation

@tomczoink

@tomczoinktomczoink commented Apr 15, 2020

Copy link
Copy Markdown
Contributor
  • Updates the client lib spec to v1.2, adding in a diff and v1.1 folder
  • Adds seperate versioning for client lib folder and doc folders, so as to allow the version of the spec to change prior to the version of the rest of the docs. This can be easily extended to other folders in the future if needed

The 1.2 spec changes have been taken from #843.

@mattheworiordan
mattheworiordan temporarily deployed to ably-docs-1-2-spec-7clzrwhkhbr April 15, 2020 15:47 Inactive

@SimonWoolfSimonWoolf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the same comment I made here: the 1.1->1.2 diff is not right, looks like it's from 1.1-as-amended to 1.2 when it should be from 1.1 to 1.2 - that is, it should include all the changes that have been added to the 1.1 spec since its initial release, which are required for 1.2 compliance per https://github.com/ably/docs/#branch-and-tag-scheme-for-features-spec.

(To put it another way: it should be the case that if you start with the 0.8 spec, and apply the 0.8->1.0, 1.0->1.1, and 1.1->1.2 diffs, you get to the 1.2 spec, which meaqns that the endpoint of the last diff needs to be the startpoint of the next one)

- Updates the client lib spec to v1.2
- Adds seperate versioning for client lib folder and doc folders, so as to allow staggered changes
@mattheworiordan
mattheworiordan temporarily deployed to ably-docs-1-2-spec-sh7rpatdpbn April 16, 2020 11:11 Inactive
@tomczoink
tomczoink merged commit 261d27a into masterApr 16, 2020
@tomczoink
tomczoink deleted the 1.2-spec branch April 16, 2020 12:04
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tomczoink@SimonWoolf@mattheworiordan