Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Aug 10, 2026. It is now read-only.
Conversation
mattheworiordan
temporarily deployed
to
ably-docs-1-2-spec-7clzrwhkhbr
April 15, 2020 15:47
Inactive
SimonWoolf
suggested changes
Apr 16, 2020
SimonWoolf
left a comment
Member
There was a problem hiding this comment.
LGTM, except for the same comment I made here: the 1.1->1.2 diff is not right, looks like it's from 1.1-as-amended to 1.2 when it should be from 1.1 to 1.2 - that is, it should include all the changes that have been added to the 1.1 spec since its initial release, which are required for 1.2 compliance per https://github.com/ably/docs/#branch-and-tag-scheme-for-features-spec.
(To put it another way: it should be the case that if you start with the 0.8 spec, and apply the 0.8->1.0, 1.0->1.1, and 1.1->1.2 diffs, you get to the 1.2 spec, which meaqns that the endpoint of the last diff needs to be the startpoint of the next one)
- Updates the client lib spec to v1.2 - Adds seperate versioning for client lib folder and doc folders, so as to allow staggered changes
mattheworiordan
temporarily deployed
to
ably-docs-1-2-spec-sh7rpatdpbn
April 16, 2020 11:11
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1.2 spec changes have been taken from #843.