Uh oh!
There was an error while loading. Please reload this page.
1.2.0 Feature: Realtime: Channel Modes - #33
Merged
Conversation
QuintinWillison
marked this pull request as ready for review
August 15, 2022 10:55
QuintinWillison
requested review from
a user, lmars, owenpearson, qsdstefan and stmoreauAugust 15, 2022 10:55
lmars
reviewed
Sep 5, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Base automatically changed from
realtime-delta-subscription-enhancements to
mainSeptember 9, 2022 08:22
QuintinWillisonforce-pushed
the
realtime-channel-modes
branch
from
September 9, 2022 08:35
53c2d68 to
786fe4cCompareQuintinWillison
marked this pull request as draft
September 9, 2022 08:37
QuintinWillison
commented
Sep 9, 2022
ContributorAuthor
I have made a mistake with Git merges. Trying to resolve. |
… via options for a channel within a Realtime client instance. I could see no evidence that the Ruby SDK supports this.
QuintinWillisonforce-pushed
the
realtime-channel-modes
branch
from
September 9, 2022 08:39
462b59b to
266d754CompareQuintinWillison
marked this pull request as ready for review
September 9, 2022 08:41
…mentary contributed by @SimonWoolf.
QuintinWillison
commented
Sep 9, 2022
ContributorAuthor
Having addressed @lmars' comment with help from @SimonWoolf, I'm going to merge this pull request without waiting for approval. It has been open for a while and there is a stack of pull requests ahead of it. We are likely to have another look at the entire work at the end, to double check that it congeals holistically, so the risk of merge without approval is low. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could see no evidence that the Ruby SDK supports this.
One of a family of pull requests addressing #3.