Uh oh!
There was an error while loading. Please reload this page.
Fallback retry conditions: split up RSC15d into individual items, add a new one - #123
Conversation
4ffc44f to
93fcdd1CompareUh oh!
There was an error while loading. Please reload this page.
owenpearson
left a comment
There was a problem hiding this comment.
I don't know under which conditions you would get a 400+ error from cloudfront so can't comment on that, but in terms of SDK implementation changes, all LGTM
Uh oh!
There was an error while loading. Please reload this page.
5987d3d to
9e66f95Compare
QuintinWillison
left a comment
There was a problem hiding this comment.
Noticing that this pull request is targeting the main (default) branch, the 'bleeding edge' of the current specification version 1.2, rather than the integration/protocol-2.0 branch (#108)... I think we should simplify these statements, as the new form guidance is only introduced from specification version 2.0.0 (#120).
(or, alternatively, if you prefer then you could rebase this PR atop the v2 integration branch)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
SimonWoolf
commented
Dec 16, 2022
Given we're making it on ably-go which does not confirm to 2.0 spec, I think it probably makes sense to keep this pr against |
155051c to
14a0947CompareFallback retry conditions: split up RSC15d into individual items, add a new one
Fallback retry conditions: split up RSC15d into individual items, add a new one
per https://ably.atlassian.net/browse/INC-230