Skip to content

Fallback retry conditions: split up RSC15d into individual items, add a new one - #123

Merged
QuintinWillison merged 2 commits into
mainfrom
new-qualifying-condition
Dec 19, 2022
Merged

Fallback retry conditions: split up RSC15d into individual items, add a new one#123
QuintinWillison merged 2 commits into
mainfrom
new-qualifying-condition

Conversation

@SimonWoolf

Copy link
Copy Markdown
Member

@github-actions
github-actionsBot temporarily deployed to staging/pull/123 December 7, 2022 17:25 Inactive
@SimonWoolf
SimonWoolfforce-pushed the new-qualifying-condition branch from 4ffc44f to 93fcdd1CompareDecember 7, 2022 17:52
@github-actions
github-actionsBot temporarily deployed to staging/pull/123 December 7, 2022 17:52 Inactive
Comment threadtextile/features.textile Outdated

@owenpearsonowenpearson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know under which conditions you would get a 400+ error from cloudfront so can't comment on that, but in terms of SDK implementation changes, all LGTM

Comment threadtextile/features.textile Outdated
@SimonWoolf
SimonWoolfforce-pushed the new-qualifying-condition branch 2 times, most recently from 5987d3d to 9e66f95CompareDecember 12, 2022 20:20
@github-actions
github-actionsBot temporarily deployed to staging/pull/123 December 12, 2022 20:21 Inactive

@QuintinWillisonQuintinWillison left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticing that this pull request is targeting the main (default) branch, the 'bleeding edge' of the current specification version 1.2, rather than the integration/protocol-2.0 branch (#108)... I think we should simplify these statements, as the new form guidance is only introduced from specification version 2.0.0 (#120).

(or, alternatively, if you prefer then you could rebase this PR atop the v2 integration branch)

Comment threadtextile/features.textile Outdated
Comment threadtextile/features.textile Outdated
@github-actions
github-actionsBot temporarily deployed to staging/pull/123 December 16, 2022 17:59 Inactive
@SimonWoolf

Copy link
Copy Markdown
MemberAuthor

Given we're making it on ably-go which does not confirm to 2.0 spec, I think it probably makes sense to keep this pr against main. Made those changes

@QuintinWillison
QuintinWillison merged commit 6a1d650 into mainDec 19, 2022
@QuintinWillison
QuintinWillison deleted the new-qualifying-condition branch December 19, 2022 15:46
ttypic pushed a commit that referenced this pull request Mar 6, 2026
Fallback retry conditions: split up RSC15d into individual items, add a new one
ttypic pushed a commit that referenced this pull request Mar 6, 2026
Fallback retry conditions: split up RSC15d into individual items, add a new one
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@SimonWoolf@QuintinWillison@owenpearson