[SDK-3561] New batch specs by owenpearson · Pull Request #139 · ably/specification

owenpearson · 2023-04-28T16:40:30Z

Resolves#140

Doing this now so that we can publish this as spec v2.1 before working on spec v3

Adds new specs for batch REST methods, using the new batch response format via the newBatchResponse query param.

For further information, see:

lawrence-forooghian

As well as the comments below, I also wanted to mention that we need to write documentation comments for these new APIs and open a PR into https://github.com/ably/sdk-api-reference. The process described by EdX DR 5.4 isn't quite clear about when this should happen, but I’d suggest that it would be best to do it alongside the spec PR (i.e. now), so that reviewers of the spec PR can also understand how the new functionality is meant to be used by users.

SimonWoolf

Looks good, couple comments

lawrence-forooghian

Looks good, one outstanding question about the messageId response property, but feel free to resolve and merge if you consider it a non-blocker.

These were never implemented in any SDK so is safe to remove without deprectation

Co-authored-by: Lawrence Forooghian <lawrence@forooghian.com>

New batch specs

owenpearson requested review from a team, SimonWoolf, lawrence-forooghian and lmars April 28, 2023 16:40

github-actionsBot temporarily deployed to staging/pull/139 April 28, 2023 16:41 Inactive

owenpearson force-pushed the new-batch-specs branch from f1ca8c0 to 2203f17Compare April 28, 2023 16:42

github-actionsBot temporarily deployed to staging/pull/139 April 28, 2023 16:42 Inactive

owenpearson force-pushed the new-batch-specs branch from 2203f17 to b903f90Compare April 28, 2023 16:48

github-actionsBot temporarily deployed to staging/pull/139 April 28, 2023 16:48 Inactive

lawrence-forooghian reviewed May 1, 2023
View reviewed changes

owenpearson force-pushed the new-batch-specs branch from b903f90 to e3eb6fbCompare May 2, 2023 08:16

github-actionsBot temporarily deployed to staging/pull/139 May 2, 2023 08:16 Inactive

owenpearson force-pushed the new-batch-specs branch from e3eb6fb to 24e8317Compare May 2, 2023 08:43

github-actionsBot temporarily deployed to staging/pull/139 May 2, 2023 08:43 Inactive

SimonWoolf approved these changes May 2, 2023
View reviewed changes

Comment threadtextile/features.textile Outdated
Comment threadtextile/features.textile Outdated
Comment threadtextile/features.textile Outdated
Comment threadtextile/features.textile Outdated
Comment threadtextile/features.textile Outdated
Comment threadtextile/features.textile Outdated

owenpearson force-pushed the new-batch-specs branch from 24e8317 to 08c4a9cCompare May 2, 2023 13:59

github-actionsBot temporarily deployed to staging/pull/139 May 2, 2023 13:59 Inactive

owenpearson requested a review from lawrence-forooghian May 2, 2023 14:02

lawrence-forooghian reviewed May 3, 2023
View reviewed changes

Comment threadtextile/features.textile Outdated

lawrence-forooghian reviewed May 3, 2023
View reviewed changes

Comment threadtextile/features.textile Outdated
Comment threadtextile/features.textile Outdated

owenpearson force-pushed the new-batch-specs branch from 08c4a9c to b1c42d0Compare May 4, 2023 10:41

github-actionsBot temporarily deployed to staging/pull/139 May 4, 2023 10:42 Inactive

owenpearson force-pushed the new-batch-specs branch from b1c42d0 to b511642Compare May 4, 2023 10:46

github-actionsBot temporarily deployed to staging/pull/139 May 4, 2023 10:46 Inactive

owenpearson requested a review from lawrence-forooghian May 4, 2023 10:53

owenpearson force-pushed the new-batch-specs branch from b511642 to cfa3e5dCompare May 4, 2023 14:12

github-actionsBot temporarily deployed to staging/pull/139 May 4, 2023 14:13 Inactive

owenpearson force-pushed the new-batch-specs branch from cfa3e5d to 9ee13a4Compare May 4, 2023 15:15

github-actionsBot temporarily deployed to staging/pull/139 May 4, 2023 15:15 Inactive

owenpearson mentioned this pull request May 4, 2023
Add descriptions for new batch APIs ably/sdk-api-reference#33
Merged

owenpearson force-pushed the new-batch-specs branch from 9ee13a4 to 9762cc3Compare May 4, 2023 16:16

github-actionsBot temporarily deployed to staging/pull/139 May 4, 2023 16:16 Inactive

lawrence-forooghian reviewed May 15, 2023
View reviewed changes

Comment threadtextile/features.textile Outdated

lawrence-forooghian reviewed May 15, 2023
View reviewed changes

Comment threadtextile/features.textile Outdated
Comment threadtextile/features.textile Outdated
Comment threadtextile/features.textile Outdated

lawrence-forooghian reviewed May 15, 2023
View reviewed changes

Comment threadtextile/features.textile Outdated
Comment threadtextile/features.textile Outdated

owenpearson force-pushed the new-batch-specs branch from 9762cc3 to 2b8410cCompare May 17, 2023 08:56

github-actionsBot temporarily deployed to staging/pull/139 May 17, 2023 08:57 Inactive

owenpearson requested a review from lawrence-forooghian May 17, 2023 08:57

lawrence-forooghian approved these changes May 17, 2023
View reviewed changes

owenpearson mentioned this pull request May 17, 2023
Implement new batch API specs ably/ably-js#1268
Open

SimonWoolf mentioned this pull request Jul 18, 2023
RFC: improvements to rest#request #103
Open

lawrence-forooghian reviewed Jul 20, 2023
View reviewed changes

Comment threadtextile/features.textile Outdated

lawrence-forooghian reviewed Jul 20, 2023
View reviewed changes

Comment threadtextile/features.textile Outdated

lawrence-forooghian reviewed Jul 20, 2023
View reviewed changes

Comment threadtextile/features.textile Outdated

lawrence-forooghian force-pushed the new-batch-specs branch from 2b8410c to 38536aeCompare July 20, 2023 16:30

owenpearsonand others added 3 commits July 20, 2023 13:30

remove existing batch specs
36ddc21
These were never implemented in any SDK so is safe to remove without deprectation

feat: add RestClient#batchPublish specs
ee3866f

feat: add RestClient#batchPresence specs
038b50e
Co-authored-by: Lawrence Forooghian <lawrence@forooghian.com>

lawrence-forooghian force-pushed the new-batch-specs branch from 38536ae to 9d38a1cCompare July 20, 2023 16:30

github-actionsBot temporarily deployed to staging/pull/139 July 20, 2023 16:31 Inactive

lawrence-forooghian reviewed Jul 20, 2023
View reviewed changes

Comment threadtextile/features.textile Outdated

feat: add Auth#revokeTokens specs
97186e7
Co-authored-by: Lawrence Forooghian <lawrence@forooghian.com>

lawrence-forooghian force-pushed the new-batch-specs branch from 9d38a1c to 97186e7Compare July 24, 2023 11:42

github-actionsBotdeployed to staging/pull/139 July 24, 2023 11:42 View deployment

lawrence-forooghian merged commit 85f1a39 into mainJul 24, 2023

lawrence-forooghian deleted the new-batch-specs branch July 24, 2023 13:07

lawrence-forooghian mentioned this pull request Jul 25, 2023
[SDK-1904] Implement batch operations ably/ably-js#1410
Merged

hayleynewton changed the title ~~New batch specs~~[SDK-3561] New batch specsJul 27, 2023

ttypic pushed a commit that referenced this pull request Mar 6, 2026
Merge pull request#139from ably/new-batch-specs
8c4a09f
New batch specs

ttypic pushed a commit that referenced this pull request Mar 6, 2026
Merge pull request#139from ably/new-batch-specs
021a5b8
New batch specs

Uh oh!

Conversation

owenpearson commented Apr 28, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lawrence-forooghian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SimonWoolf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lawrence-forooghian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

owenpearson commented Apr 28, 2023•
edited
Loading