Uh oh!
There was an error while loading. Please reload this page.
Tweak spec for Rest.request’s version param - #145
Merged
lawrence-forooghian merged 2 commits intoMay 2, 2023
Conversation
CSV2a says that the protocol version is an integer.
lawrence-forooghianforce-pushed
the
tweak-spec-for-request-version-param
branch
from
May 1, 2023 18:56
688fe9d to
c184af0Comparelawrence-forooghian added a commit
to ably/ably-js
that referenced
this pull request
May 1, 2023
As described by RSC19f1. Approach for mocking HTTP request handling copied from http.test.js. The test changes are minimal (just adding an extra argument to a few calls) but Prettier has decided to do some re-indentation that makes them look larger than they are. Waiting on: - ably/specification#143 - ably/specification#145 - ably/sdk-api-reference#32
lawrence-forooghian added a commit
to ably/ably-js
that referenced
this pull request
May 1, 2023
As described by RSC19f1. Approach for mocking HTTP request handling copied from http.test.js. The test changes are minimal (just adding an extra argument to a few calls) but Prettier has decided to do some re-indentation that makes them look larger than they are. Waiting on: - ably/specification#143 - ably/specification#145 - ably/sdk-api-reference#32
lawrence-forooghian added a commit
to ably/ably-js
that referenced
this pull request
May 1, 2023
As described by RSC19f1. Approach for mocking HTTP request handling copied from http.test.js. The test changes are minimal (just adding an extra argument to a few calls) but Prettier has decided to do some re-indentation that makes them look larger than they are. Waiting on: - ably/specification#143 - ably/specification#145 - ably/sdk-api-reference#32Resolves#1225.
SimonWoolf
approved these changes
May 2, 2023
Base automatically changed from
reintroduce-breaking-api-changes to
integration/3.0.0May 2, 2023 12:02
There’s still a question of how this method is meant to behave if the user also specifies an `X-Ably-Header` header in the `headers` parameter. But it’s a question that equally applied before adding the `version` parameter, so I’ve captured it in a separate issue #144. Same comment as 69e1973 re needing to update "replaced in" spec version before merging integration branch into `main` applies here too.
lawrence-forooghianforce-pushed
the
tweak-spec-for-request-version-param
branch
from
May 2, 2023 12:05
c184af0 to
c653156Comparettypic pushed a commit
that referenced
this pull request
Mar 6, 2026
Tweak spec for `Rest.request`’s `version` param
ttypic pushed a commit
that referenced
this pull request
Mar 6, 2026
Tweak spec for `Rest.request`’s `version` param
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is based on top of PR #143 — please review that one first.
This tweaks the type of this param and describes how the library is meant to use it. See commit messages for more details.
The related PR ably/sdk-api-reference#32 adds documentation for this parameter.