Uh oh!
There was an error while loading. Please reload this page.
Clarify how echoMessages should be implemented - #198
Conversation
0de9c0d to
266fe86CompareUh oh!
There was an error while loading. Please reload this page.
266fe86 to
1b5f05bCompareClarify how `echoMessages` should be implemented
Clarify how `echoMessages` should be implemented
SimonWoolf
commented
May 5, 2026
@lawrence-forooghian what was the purpose of this change? And this isn't exactly a clarification, it's a material change in behaviour -- before this pr a lib only needs to set the echo qs param if the user specifies echoMessages=false, after this pr it must set it always? |
lawrence-forooghian
commented
May 7, 2026
The intention of this change was to make it clear what a client needed to do in order to implement the behaviour described in RTC1a: "If false, it prevents messages originating from this connection being echoed back on the same connection". It does this by stating that this is achieved by using the
I don't agree — even before this, it still said " But yes, if |
SimonWoolf
commented
May 7, 2026
Fair point, that item was very poorly phrased -- it's one of those very early ones which were terrible for confusing SDK implementation requirements with expected overall system behaviour |
No description provided.