Uh oh!
There was an error while loading. Please reload this page.
Updated message spec and related endpoints - #270
Open
sacOO7 wants to merge 3 commits into
Open
Conversation
sacOO7force-pushed
the
fix/operation-struct
branch
from
January 21, 2025 13:50
1d76f98 to
9b04985ComparesacOO7
marked this pull request as ready for review
January 21, 2025 13:52
This was referenced Jan 22, 2025
sacOO7force-pushed
the
fix/operation-struct
branch
from
January 22, 2025 12:09
a948cc6 to
a5baa77ComparesacOO7force-pushed
the
fix/operation-struct
branch
from
January 22, 2025 12:18
cc5a3dc to
19d3a9dCompareAndyTWF
reviewed
Feb 13, 2025
| Below is the full REST payload format for the endpoint. The @description@, @headers@ and both @metadata@ keys are optional. | ||
| Note that outer @metadata@ is of type map<string, string>. |
Contributor
There was a problem hiding this comment.
Suggested change
| Note that outer @metadata@ is of type map<string, string>. | |
| Note that the root level @metadata@ field is of type map<string, string>. |
| Below is the full REST payload format for the V2 endpoint. The @metadata@ and @headers@ keys are optional. | ||
| Note that @metadata@ is of type map<string, any> or jsonObject. |
Contributor
There was a problem hiding this comment.
We probably don't need to specify jsonObject here - map<string, any> covers everything?
| "baz": "qux" | ||
| }, | ||
| } | ||
| "createdAt": 1726232498871, |
Contributor
There was a problem hiding this comment.
The timestamp here should match that in the serial.
| } | ||
| "serial": "01726232498871-001@abcdefghij:001", | ||
| "version": "01726585978590-001@abcdefghij:001" | ||
| "serial": "01726585978590-001@abcdefghij:001", |
Contributor
There was a problem hiding this comment.
The createdAt should match the timestamp in the serial.
lawrence-forooghian
commented
Apr 9, 2025
Contributor
Hey @sacOO7, this one has been open for a while; I was wondering if you're planning to address the feedback? |
sacOO7
commented
Apr 10, 2025
ContributorAuthor
Yeah thanks @lawrence-forooghian I am planning to address this 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.