Uh oh!
There was an error while loading. Please reload this page.
Add API for tracking usage of wrapper SDKs - #273
Merged
Conversation
lawrence-forooghian
requested review from
VeskeR, maratal, sacOO7, ttypic and umair-ablyFebruary 11, 2025 20:10
lawrence-forooghian
commented
Feb 12, 2025
ContributorAuthor
Ah, need to add docstrings, will do that now. |
lawrence-forooghianforce-pushed
the
wrapper-sdk-proxy
branch
from
February 12, 2025 12:20
f97a7cf to
b53e493Comparelawrence-forooghianforce-pushed
the
wrapper-sdk-proxy
branch
from
February 12, 2025 12:23
b53e493 to
45b9796Comparelawrence-forooghian
commented
Feb 12, 2025
ContributorAuthor
Done. |
AndyTWF
reviewed
Feb 12, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
3 tasks
ttypic
reviewed
Feb 12, 2025
Uh oh!
There was an error while loading. Please reload this page.
lawrence-forooghianforce-pushed
the
wrapper-sdk-proxy
branch
from
February 17, 2025 19:59
45b9796 to
959085fComparelawrence-forooghianforce-pushed
the
wrapper-sdk-proxy
branch
from
February 17, 2025 20:27
959085f to
a605a4fCompareAndyTWF
approved these changes
Feb 18, 2025
ttypic
approved these changes
Feb 18, 2025
This specifies the API agreed in ADR-117 [1], to allow us to track usage of a "modern wrapper SDK" (the term used in that ADR to refer to a wrapper SDK which accepts an already-instantiated core SDK client). We will use it to track usage of the Chat SDK. The functionality described here has already been partially implemented in ably-cocoa [2] and is being used by ably-chat-swift [3]. I found it quite hard to write a spec for this, and the language might still be both too vague and too convoluted. I'm putting this up for review as a first attempt in order not to end up getting stuck trying to write something perfect. [1] https://ably.atlassian.net/wiki/spaces/ENG/pages/3413016589/ADR-117+Tracking+wrapper+SDK+usage+continued [2] ably/ably-cocoa#2014 [3] ably/ably-chat-swift#211
lawrence-forooghianforce-pushed
the
wrapper-sdk-proxy
branch
from
February 18, 2025 13:18
a605a4f to
c5fa643Comparettypic pushed a commit
that referenced
this pull request
Mar 6, 2026
Add API for tracking usage of wrapper SDKs
ttypic pushed a commit
that referenced
this pull request
Mar 6, 2026
Add API for tracking usage of wrapper SDKs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This specifies the API agreed in ADR-117, to allow us to track usage of a "modern wrapper SDK" (the term used in that ADR to refer to a wrapper SDK which accepts an already-instantiated core SDK client). We will use it to track usage of the Chat SDK.
The functionality described here has already been partially implemented in ably-cocoa (ably/ably-cocoa#2014) and is being used by ably-chat-swift (ably/ably-chat-swift#211).
I found it quite hard to write a spec for this, and the language might still be both too vague and too convoluted. I'm putting this up for review as a first attempt in order not to end up getting stuck trying to write something perfect.