Uh oh!
There was an error while loading. Please reload this page.
Add mandatory version param for rest#request. - #89
Merged
QuintinWillison merged 2 commits intoOct 20, 2022
Conversation
This was referenced Oct 3, 2022
QuintinWillison
suggested changes
Oct 3, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
SimonWoolfforce-pushed
the
rest-request-with-version
branch
from
October 3, 2022 21:39
1ce0898 to
1197e58CompareQuintinWillison
approved these changes
Oct 5, 2022
QuintinWillison
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, but I'll add a couple of other reviewers so we can perhaps get more than just my approval before we land this.
owenpearson
approved these changes
Oct 5, 2022
stmoreau
approved these changes
Oct 17, 2022
ttypic pushed a commit
that referenced
this pull request
Mar 6, 2026
Add mandatory version param for rest#request.
ttypic pushed a commit
that referenced
this pull request
Mar 6, 2026
Add mandatory version param for rest#request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds mandatory version param to rest#request for protocol version 2.0, per https://ably.atlassian.net/wiki/spaces/ENG/pages/2222456951/ADR61+Versioning+of+realtime+API+endpoints