Uh oh!
There was an error while loading. Please reload this page.
Add OBJECT, OBJECT_SYNC, ANNOTATION protocol message actions - #3
Open
paddybyers wants to merge 1 commit into
Open
Add OBJECT, OBJECT_SYNC, ANNOTATION protocol message actions#3paddybyers wants to merge 1 commit into
paddybyers wants to merge 1 commit into
Conversation
Add missing action constants from TR2: OBJECT (19), OBJECT_SYNC (20), and ANNOTATION (21). Without these, rules using named actions like "OBJECT" would silently fail to match, and log output would show numeric IDs instead of readable names. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"OBJECT"silently fail to match (fall through tostrconv.Atoiwhich returns -1 for a name string), and log output shows numeric IDs instead of readable namesContext
Raised in ably/specification#473 (comment) — the UTS LiveObjects integration tests need proxy rules that match on OBJECT and OBJECT_SYNC frames.
Test plan
go buildpassesgo testpasses (existing tests unaffected — no tests currently use OBJECT actions)🤖 Generated with Claude Code