Uh oh!
There was an error while loading. Please reload this page.
Fix 180: Add environment variables to Click CLI options - #187
Merged
Conversation
pombredanne
requested changes
Aug 14, 2024
calizarrforce-pushed
the
fix-180-env-vars
branch
from
August 15, 2024 16:58
4b0129f to
77d09daComparecalizarr
commented
Aug 15, 2024
ContributorAuthor
I believe I've just rebased and added my signature. |
Contributor
@calizarr not all the commits have the sign-off, neither the PR description have it |
ContributorAuthor
Alright, I'll try again. Not entirely sure how to add it to the PR description though |
Contributor
Something like this
in the end of PR description |
calizarrforce-pushed
the
fix-180-env-vars
branch
6 times, most recently
from
August 26, 2024 19:10
fe1df6c to
ce07ad6CompareSigned-off-by: Cesar Lizarraga <calizarr@gmail.com>
calizarrforce-pushed
the
fix-180-env-vars
branch
from
August 26, 2024 19:12
ce07ad6 to
8b25fc8CompareSigned-off-by: Cesar Lizarraga <calizarr@gmail.com>
They should be able to use the same ones as the flag. Signed-off-by: Cesar Lizarraga <calizarr@gmail.com>
Signed-off-by: Cesar Lizarraga <calizarr@gmail.com>
calizarrforce-pushed
the
fix-180-env-vars
branch
from
August 26, 2024 19:13
8b25fc8 to
c34aaa9CompareContributorAuthor
All commits should be signed off now. @pombredanne@TG1999 |
Adjust for too long filenames where there's basic auth aka: https://username:password@URL
Signed-off-by: Cesar Lizarraga <calizarr@gmail.com> Fix 180: Add env var for netrc file
calizarrforce-pushed
the
fix-180-env-vars
branch
from
December 18, 2024 23:24
0c82fb8 to
056a825CompareMarcelBochtler
commented
Mar 10, 2025
Contributor
@pombredanne what is missing from this PR to get it merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will add environment variables as extra options for the index-url flag. Click will split on whitespace for multiple values by default.
Added a possibly unnecessary test to make sure that flags override environment variables.
Signed-off-by: Cesar Lizarraga calizarr@gmail.com