Skip to content

Migrate apache httpd importer#971 - #1014

Merged
TG1999 merged 14 commits into
mainfrom
971-migrate-apache-httpd-importer
Jan 6, 2023
Merged

Migrate apache httpd importer#971#1014
TG1999 merged 14 commits into
mainfrom
971-migrate-apache-httpd-importer

Conversation

@johnmhoran

@johnmhoranjohnmhoran commented Nov 22, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Applies to Issue #971.

@johnmhoran
johnmhoranforce-pushed the 971-migrate-apache-httpd-importer branch from 07ad467 to 49b51c8CompareNovember 29, 2022 00:36
TG1999
TG1999 reviewed Dec 7, 2022
View reviewed changes
Comment threadvulnerabilities/importers/apache_httpd.py Outdated
pombredanne
pombredanne requested changes Dec 13, 2022
View reviewed changes

@pombredannepombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! here are a few nitpickings for your consideration

Comment threadvulnerabilities/tests/test_apache_httpd.py Outdated
Comment threadvulnerabilities/importers/apache_httpd.py Outdated
Comment threadvulnerabilities/importers/apache_httpd.py Outdated
Comment threadvulnerabilities/importers/apache_httpd.py
Comment threadvulnerabilities/importers/apache_httpd.py Outdated
Comment threadvulnerabilities/importers/apache_httpd.py
Comment threadvulnerabilities/importers/apache_httpd.py Outdated
Comment threadvulnerabilities/importers/apache_httpd.py Outdated
Comment threadvulnerabilities/improvers/default.py
@johnmhoran

johnmhoran commented Dec 13, 2022

Copy link
Copy Markdown
MemberAuthor

Thanks @pombredanne . @TG1999 -- would you like me to make the changes @pombredanne has suggested and push my updated code before you start your review, or shall I wait for your comments?

@TG1999

TG1999 commented Dec 13, 2022

Copy link
Copy Markdown
Contributor

@johnmhoran please address @pombredanne review comments and push the updated code.

@johnmhoran

johnmhoran commented Dec 13, 2022

Copy link
Copy Markdown
MemberAuthor

Thank you @TG1999 -- will do.

pombredanne
pombredanne requested changes Dec 24, 2022
View reviewed changes

@pombredannepombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks. We just need a CHANGELOG entry

TG1999
TG1999 approved these changes Jan 3, 2023
View reviewed changes

@TG1999TG1999 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

johnmhoranand others added 12 commits January 3, 2023 11:16
@johnmhoran
Explore testing#971
d2f2fb5
Reference: #971
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Update testing and importer#971
cea5879
Reference: #971
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Update importer and test files#971
749cc36
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@TG1999@johnmhoran
Add affected package in apache_httpd importer
663598c
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@johnmhoran
Update and clean importer, replace existing tests with 3 new tests#971
e664956
Reference: #971
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Update code and test to address problematic comparator#971
6518950
Reference: #971
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Update to use .invert()#971
1d1df82
Reference: #971
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@TG1999@johnmhoran
Modify get_exact_purls to support multiple fixed versions in an affec…
b77529c
…ted_package
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@johnmhoran
Add test for unknown comparator exception#971
3af6192
Reference: #971
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Update fixed-version code and add test for 'never released' values#971
1e79bc6
Reference: #971
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Refactor importer and test files#971
71e52a2
Reference: #971
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Refactor, add test and clean up#971
0b74c9f
Reference: #971
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoranjohnmhoran changed the title Migrate apache httpd importerMigrate apache httpd importer #971Jan 3, 2023
@johnmhoranjohnmhoran linked an issue Jan 3, 2023 that may be closed by this pull request
Migrate apache_httpd #971
Closed
@johnmhoran
johnmhoranforce-pushed the 971-migrate-apache-httpd-importer branch from a49f502 to 0b74c9fCompareJanuary 3, 2023 20:07
@johnmhoranjohnmhoran changed the title Migrate apache httpd importer #971Migrate apache httpd importer#971Jan 3, 2023
@johnmhoran
Add changelog entry for apache_httpd#971
bb539b8
Reference: #971
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
TG1999
TG1999 requested changes Jan 6, 2023
View reviewed changes

@TG1999TG1999 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions

Comment threadCHANGELOG.rst Outdated
Comment threadvulnerabilities/importers/apache_httpd.py Outdated
Comment threadvulnerabilities/importers/apache_httpd.py Outdated
Comment threadvulnerabilities/importers/apache_httpd.py Outdated
Comment threadvulnerabilities/importers/apache_httpd.py Outdated
Comment threadvulnerabilities/tests/test_data/apache_httpd/CVE-2021-44224-apache-httpd-expected.json Outdated
Comment threadvulnerabilities/tests/test_data/apache_httpd/CVE-2021-44224-apache-httpd-expected.json Outdated
Comment threadvulnerabilities/tests/test_data/apache_httpd/CVE-2022-28614-apache-httpd-expected.json Outdated
Comment threadvulnerabilities/tests/test_data/apache_httpd/CVE-2022-28614-apache-httpd-expected.json Outdated
Comment threadvulnerabilities/tests/test_data/apache_httpd/CVE-2022-28614-apache-httpd-expected.json Outdated
@TG1999
Apply suggestions from code review
b689916
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
TG1999 approved these changes Jan 6, 2023
View reviewed changes

@TG1999TG1999 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pombredanne
pombredanne approved these changes Jan 6, 2023
View reviewed changes

@pombredannepombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TG1999
TG1999 merged commit f3058d1 into mainJan 6, 2023
@TG1999
TG1999 deleted the 971-migrate-apache-httpd-importer branch January 6, 2023 15:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pombredannepombredannepombredanne approved these changes
@TG1999TG1999TG1999 approved these changes

Assignees

No one assigned

Labels

import-improver-migration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate apache_httpd

3 participants

@johnmhoran@TG1999@pombredanne