Skip to content

Add models for CodeFix - #1704

Merged
TG1999 merged 11 commits into
mainfrom
collect_fix_commits
Jan 10, 2025
Merged

Add models for CodeFix#1704
TG1999 merged 11 commits into
mainfrom
collect_fix_commits

Conversation

@TG1999

@TG1999TG1999 commented Dec 20, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

pombredanne
pombredanne reviewed Dec 20, 2024
View reviewed changes

@pombredannepombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Here are a few comments for your consideration.
IMHO I am not sure we want a PURL for a commit, we should consider using vcs URLs rather than a plain commit id...

I am open to something else that we can design, but if we do that we need a way to get back to the commit.

We are going to have cases that are NOT on GitHub and therefore are just plain git coordinates.

Comment threadvulnerabilities/models.py Outdated
Comment threadvulnerabilities/models.py Outdated
Comment threadvulnerabilities/models.py Outdated
Comment threadvulnerabilities/pipelines/collect_commits.py Outdated
Comment threadvulnerabilities/pipelines/collect_commits.py Outdated
if commit_id and package_urls:
for purl in package_urls:
normalized_purl = normalize_purl(purl)
package = self.get_or_create_package(normalized_purl)

@pombredannepombredanneDec 20, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to create new packages here? I would have thought we are only adding new CodeFix?

Comment threadvulnerabilities/pipelines/collect_commits.py Outdated
Comment threadvulnerabilities/pipelines/collect_commits.py Outdated
Comment threadvulnerabilities/pipelines/collect_commits.py Outdated
Comment threadvulnerabilities/pipelines/collect_commits.py Outdated
@TG1999TG1999 changed the title Add models for CodeFixWIP: Add models for CodeFixJan 1, 2025
@TG1999
TG1999 marked this pull request as draft January 1, 2025 13:41
@TG1999
Add models for CodeFix
8519b0d
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Add pipeline to collect fix commit
6f984c3
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Address review comments
bcdc572
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Fix
b3c0ef2
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Model changes
c01f6ec
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Refactor the collect fix commit pipeline
48d2144
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Add tests
991fbeb
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Add CodeFix in API
7bb44be
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
TG1999force-pushed the collect_fix_commits branch from 2b66214 to 7bb44beCompareJanuary 8, 2025 14:52
@TG1999

TG1999 commented Jan 8, 2025

Copy link
Copy Markdown
ContributorAuthor

Screenshot from 2025-01-08 20-21-06

Screenshot from 2025-01-08 20-21-28
API support is also added!

@TG1999TG1999 changed the title WIP: Add models for CodeFixAdd models for CodeFixJan 8, 2025
@TG1999
Fix code
805590b
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
TG1999 marked this pull request as ready for review January 8, 2025 14:57
@TG1999
Minor Fix
3d7c209
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
keshav-space
keshav-space approved these changes Jan 10, 2025
View reviewed changes

@keshav-spacekeshav-space left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TG1999, LGTM!

@TG1999
TG1999 merged commit 80430b2 into mainJan 10, 2025
This was referenced Jan 10, 2025
Closed
Closed
@TG1999
TG1999 deleted the collect_fix_commits branch March 20, 2025 09:50
This was linked to issues Mar 21, 2025
VCIO-next: Add support to track fix commits: Include commits and patches that fix a vulnerability #207
Closed
VCIO-next: Create improver to find fix commits #1696
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pombredannepombredannepombredanne left review comments
@keshav-spacekeshav-spacekeshav-space approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VCIO-next: Create improver to find fix commits VCIO-next: Add support to track fix commits: Include commits and patches that fix a vulnerability

3 participants

@TG1999@pombredanne@keshav-space