Uh oh!
There was an error while loading. Please reload this page.
Add commit collection support to Apache Tomcat V2 importer - #2195
Add commit collection support to Apache Tomcat V2 importer#2195Dhirenderchoudhary wants to merge 4 commits into
Conversation
- Extract GitHub and GitBox commit URLs from security advisories - Create PackageCommitPatchData for each commit hash - Populate fixed_by_commit_patches on AffectedPackageV2 - Add ReferenceV2 for all fix-related URLs - Add tests for commit URL extraction, GitBox support, and pipeline integration Signed-off-by: Dhirenderchoudhary <dhirenderchoudhary0001@gmail.com>
ziadhany
left a comment
There was a problem hiding this comment.
@Dhirenderchoudhary, I really appreciate your efforts.
Please see the comments there. Also, fix the CI, run the pipeline, and share the logs.
Uh oh!
There was an error while loading. Please reload this page.
| def get_commit_patches(commit_urls): | ||
| commit_patches = [] | ||
| for url in commit_urls: | ||
| match = GITHUB_COMMIT_URL_RE.match(url) or GITBOX_COMMIT_URL_RE.match(url) | ||
| if match: | ||
| commit_hash = match.group("commit_hash") | ||
| commit_patches.append( | ||
| PackageCommitPatchData( | ||
| vcs_url=TOMCAT_VCS_URL, | ||
| commit_hash=commit_hash, | ||
| ) | ||
| ) | ||
| return commit_patches |
There was a problem hiding this comment.
use classify_patch_source or append_patch_classifications instead
see other importers like: v2_importers/aosp_importer.py
There was a problem hiding this comment.
append_patch_classifications used in my changes
Signed-off-by: Dhirenderchoudhary <dhirenderchoudhary0001@gmail.com>
8118b64 to
d93a7c8CompareDhirenderchoudhary
commented
Mar 4, 2026
It's my pleasure to work and fix some issues. let me know |
ziadhany
commented
Mar 4, 2026
You shouldn’t work on an issue that has already been assigned. There are multiple issues you can work on, for example: |
Signed-off-by: Dhirenderchoudhary <dhirenderchoudhary0001@gmail.com>
Dhirenderchoudhary
commented
Mar 11, 2026
@ziadhany please have a look when you get time |
Hi! This PR has been open for quite a while. Closing it for cleanup/maintenance purposes for mentors so that they don,t waste there time. Feel free to reopen if work continues later and ping me i'll fix . Thanks! |
Date : 2 March 2026
Developer name : Dhirender Choudhary
Description
Add commit collection support to Apache Tomcat V2 importer.
Related Issue
Closes#2129
Type of Change
Testing
Checklist
PIPELINE