Collect go vulnerabilities from github api

[sify21]

try to fix#466

[sify21]

fetching release_date for each version is very slow, commenting out those lines will make it a lot faster

[pombredanne]

@sify21 Thank you ++ for this! Let me review this in details.

[sbs2001]

Thanks for the PR @sify21 .

Most of the stuff looks very good. Thanks for updating the type hints btw.

As an improvement in clarity and readability, maybe restructure the GoproxyVersionAPI such that:

The fetch method only does one thing, it should only fetch and update the cache. It shouldn't

• Do low level stuff on modifying the obtained version_info.
• Construct the api url.

Maybe create separte functions/methods for above two.

Also some unittests would be helpful.

[sbs2001]

Thanks. This would be good to merge after

1. Adding some comments on as suggested inline. Without prior knowledge it's hard to understand the intent of the code.
2. Add some test cases or just examples in a doc string trim_url_path and escape_path methods.

[pombredanne]

Thanks!
Do you think you could add a few unit tests before we merge?

[sify21]

Hi @pombredanne, I added some tests. I don't know how to resolve conflicts on github, should I pull the latest changes and resolve the conflicts on my fork?

[pombredanne]

I added some tests. I don't know how to resolve conflicts on github, should I pull the latest changes and resolve the conflicts on my fork?

yes, you need to resolve these git conflicts locally, eventually rebasing and amending as needed and then force push to your branch once this is done

[sify21]

@pombredanne merged

[pombredanne]

Thanks! There is a merge commit that's making the DCO bot unhappy... I will ignore this

[pombredanne]

Thank you for the update. Do you mind to run black to reformat your code?
make black should be enough

[sify21]

@pombredanne reformatted

[pombredanne]

@sify21 I have added a few extra comments for your consideration.

[Hritik14]

@sify21 As the development in this branch is going on and we wanted to move ahead with #476, rebasing/merging this with/from main will likely cause merge conflicts. Please accept the incoming changes for the import statements.
Alternatively, give kdiff3 a try for solving merge conflicts, it's really smart.

[sify21]

@Hritik14 merged

[pombredanne]

isort fails... I am running isort and merging now!
Thank you ++