Migrate openssl importer to importer-improver model by keshav-space · Pull Request #648 · aboutcode-org/vulnerablecode

keshav-space · 2022-03-18T15:04:38Z

closes#615
Signed-off-by: Keshav Priyadarshi git@keshav.space

TG1999

Thanks for your contribution, please check my comments

pombredanne

Thanks! See some feedback below for your kind consideration.

Hritik14

@keshav-space Thank you for the updates!! Please consider the following suggestions. Further, we're gonna need as many tests as possible.

pombredanne

Thank for the updates...we are almost there! just a few nit pickings left.

pombredanne

Do you mind to squash and amend your commits to have a cleaner stream of commit messages?

pombredanne

We are almost there... See a few last nitpickings for your consideration before we merge

pombredanne · 2022-04-09T09:19:48Z

I merged some other code... so you have some merge conflicts to resolve now

Signed-off-by: Keshav Priyadarshi <git@keshav.space>

Migrate github importer to importer-improver model Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Work around PostgreSQL index issue Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>

Same about importer Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

This can cause endless, infinite loop of failure/restart Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Ensure that we always install "dot" locally Streamline other target Remove unused targets Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

* Format long lines in doctests. * Remove dead imports. * Convert comments to docstring Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

* Use setup.cfg rather than setup.py * Use new [dev] extra for development utilities * Use requirements.txt as constraints for pinning deps. Drop using requirements-dev.txt * Update pyproject.toml for tools including pytest, black and isort * Update Makefile and Dockerfile accordingly * Bump version to signal this is a beta * Update dockerignore and other confif files * Bump dependencies Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

This is too complex and requires more design to enable. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Reported-by: Hritik Vijay <hritikxx8@gmail.com> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

There is a precedence of /etc/vulnerablecode/.env over the local .env file in all cases Reported-by: Hritik Vijay <hritikxx8@gmail.com> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

pombredanne · 2022-04-11T14:18:05Z

Sounds like you are leaning git ;)

TG1999 reviewed Mar 21, 2022
View reviewed changes

Comment threadvulnerabilities/importers/openssl.py Outdated

TG1999 requested changes Mar 21, 2022
View reviewed changes

Comment threadvulnerabilities/importers/openssl.py Outdated
Comment threadvulnerabilities/importers/openssl.py Outdated
Comment threadvulnerabilities/importers/openssl.py Outdated
Comment threadvulnerabilities/importers/openssl.py

keshav-space commented Mar 21, 2022
View reviewed changes

Comment threadvulnerabilities/importers/openssl.py Outdated

pombredanne reviewed Mar 21, 2022
View reviewed changes

Comment threadvulnerabilities/importers/openssl.py Outdated

keshav-space requested review from TG1999 and pombredanne March 22, 2022 13:00

TG1999 reviewed Mar 22, 2022
View reviewed changes

Comment threadvulnerabilities/tests/test_openssl.py Outdated

keshav-space requested a review from TG1999 March 22, 2022 17:27

pombredanne requested changes Mar 24, 2022
View reviewed changes

keshav-space mentioned this pull request Mar 27, 2022
add from_versions in VersionRange aboutcode-org/univers#55
Merged

keshav-space requested a review from pombredanne March 31, 2022 06:46

Hritik14 requested changes Apr 4, 2022
View reviewed changes

keshav-space requested a review from Hritik14 April 4, 2022 19:36

pombredanne requested changes Apr 5, 2022
View reviewed changes

Comment threadvulnerabilities/importers/openssl.py Outdated
Comment threadvulnerabilities/importers/openssl.py Outdated
Comment threadvulnerabilities/importers/openssl.py Outdated
Comment threadvulnerabilities/tests/test_openssl.py Outdated

pombredanne requested changes Apr 8, 2022
View reviewed changes

Comment threadvulnerabilities/importers/openssl.py Outdated
Comment threadvulnerabilities/importers/openssl.py

pombredanne requested changes Apr 8, 2022
View reviewed changes

pombredanne requested changes Apr 9, 2022
View reviewed changes

Comment threadvulnerabilities/importers/openssl.py Outdated
Comment threadvulnerabilities/importers/openssl.py Outdated
Comment threadvulnerabilities/importers/openssl.py Outdated
Comment threadvulnerabilities/importers/openssl.py
Comment threadvulnerabilities/importers/openssl.py Outdated

keshav-spaceand others added 12 commits April 10, 2022 00:21

Migrate openssl importer to importer-improver model
393cd16
Signed-off-by: Keshav Priyadarshi <git@keshav.space>

Reference:#604
74422d3
Migrate github importer to importer-improver model Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Reference:https://github.com/vulnerablecode/issue/650
475e7d6
Work around PostgreSQL index issue Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Fix API crash due to model changes
0751bd9
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Fix github improver
c9e473d
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Streamline stripping V prefixes in versions
9045903
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Add tests for checking API
37aa9e1
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Fix improver framework not accepting severities
e970bc0
Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>

Be explicit about improver vs improver_class
4b7208c
Same about importer Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>

Migrate nvd importer to importer-improver model
9d80c83
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Add spdx license expression
9ebdd7c
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Add unit tests and make model changes for storing cpe as reference_id
5c7f63f
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

pombredanneand others added 27 commits April 10, 2022 00:27

Do not restart: on-failure
a820740
This can cause endless, infinite loop of failure/restart Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Aligne Makefile with SCIO
fcae8bb
Ensure that we always install "dot" locally Streamline other target Remove unused targets Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Bump to use Python 3.9 in Docker image
0b2715b
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Use vulnerablecode not scancode for images
b92ba68
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Use vulnerablecode as a container name, not web
69989f0
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Improve documentation
5da4bc6
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Use proper name
3ee4f99
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Imrpoev env var. handling in settings.py
62a99bf
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Update changelog
8678938
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Improve envt. handling
6d6f966
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Improve code format, duplication and documentation
7eb0b1a
* Format long lines in doctests. * Remove dead imports. * Convert comments to docstring Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Remove empty line
d5ae047
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Migrate pytest settings to pyproject.toml
e7a469a
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Format code
13b97e2
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Use non-deprecated logger call
1ac9256
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Correct settinsg for auth
16cb138
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Enable SessionAuthentication
cd15f54
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Make Retes API look better
d6054f1
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Remove ability to edit/create/delete from the UI
b6589f4
This is too complex and requires more design to enable. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Remove trailing spaces
3248648
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Fix typo
2d728a1
Reported-by: Hritik Vijay <hritikxx8@gmail.com> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Disable codestyle checks until we have cleaned up the code
c2893b0
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Format code
37d9616
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Improve the CHANGELOG
0998528
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Document how we load environment variables from .env
dc4b650
There is a precedence of /etc/vulnerablecode/.env over the local .env file in all cases Reported-by: Hritik Vijay <hritikxx8@gmail.com> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Merge branch 'main' into main
006d899

keshav-space closed this Apr 9, 2022

keshav-space mentioned this pull request Apr 9, 2022
Migrate OpenSSL importer to importer-improver model #690
Merged

Uh oh!

Uh oh!

Conversation

keshav-space commented Mar 18, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

TG1999 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pombredanne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hritik14 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pombredanne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pombredanne left a comment

Choose a reason for hiding this comment

Uh oh!

pombredanne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pombredanne commented Apr 9, 2022

Uh oh!

pombredanne commented Apr 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

keshav-space commented Mar 18, 2022•
edited
Loading