Add gitlab importer by TG1999 · Pull Request #662 · aboutcode-org/vulnerablecode

TG1999 · 2022-03-31T18:39:40Z

No description provided.

pombredanne

This looks good overall... we are just missing tests?

TG1999 · 2022-04-05T16:57:47Z

@pombredanne some work related to Nuget VersionRange is pending at univers side, once that is done I will add tests and the improver for this importer as well.

pombredanne

Thanks! Some partial and early feedback for your review.

pombredanne

Thanks!
I have a few review comments for your consideration.

pombredanne

Just a tiny nit left wrt. purl for npm and golang.
You should consider the namespace there IMHO when doing API lookups. Both are using / as a separator. Then please go ahead and merge!
🙇

And use NginxVersion instead of SemverVersion in Nginx importer and improver Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Return PackageURL for composer in github importer if namespace is not present Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

TG1999 · 2022-05-21T10:41:17Z

While I was at it I also solved a minor wart in github importer in this commit b7ae8dc, solving #673

TG1999 force-pushed the new_importer/gitlab branch from 94cda22 to 809ef6dCompare March 31, 2022 18:49

TG1999 changed the title ~~New importer/gitlab~~Add gitlab importer Mar 31, 2022

pombredanne requested changes Apr 5, 2022
View reviewed changes

TG1999 force-pushed the new_importer/gitlab branch from 809ef6d to 8b3d8e1Compare April 27, 2022 10:43

TG1999 force-pushed the new_importer/gitlab branch from bb4df98 to 5041b3fCompare May 5, 2022 13:52

TG1999 linked an issue May 5, 2022 that may be closed by this pull request
Add support for new GitLab community advisories #438
Closed

TG1999 force-pushed the new_importer/gitlab branch 12 times, most recently from 0ce7f2f to 5ae6aebCompare May 12, 2022 11:18

TG1999 changed the title ~~Add gitlab importer~~ Add gitlab importer and use NginxVersion instead of SemverVersion in Nginx importer and improver May 12, 2022

TG1999 force-pushed the new_importer/gitlab branch from 5ae6aeb to 9548943Compare May 12, 2022 14:11

TG1999 changed the title ~~Add gitlab importer and use NginxVersion instead of SemverVersion in Nginx importer and improver~~ Add gitlab importer May 13, 2022

TG1999 force-pushed the new_importer/gitlab branch from 2b393d8 to 8cc0045Compare May 13, 2022 15:37

pombredanne requested changes May 13, 2022
View reviewed changes

TG1999 force-pushed the new_importer/gitlab branch 6 times, most recently from d9380ca to 372a8ccCompare May 17, 2022 19:35

pombredanne reviewed May 18, 2022
View reviewed changes

Comment threadvulnerabilities/helpers.py

pombredanne reviewed May 18, 2022
View reviewed changes

Comment threadvulnerabilities/importer.py

pombredanne reviewed May 18, 2022
View reviewed changes

Comment threadvulnerabilities/importers/github.py

pombredanne requested changes May 18, 2022
View reviewed changes

TG1999 mentioned this pull request May 18, 2022
Support and validate many URL styles correctly #738
Open

TG1999 force-pushed the new_importer/gitlab branch 2 times, most recently from 5faee3f to 33d9f18Compare May 18, 2022 17:06

TG1999 mentioned this pull request May 20, 2022
Parse go package names #742
Open

pombredanne reviewed May 20, 2022
View reviewed changes

Comment threadvulnerabilities/package_managers.py Outdated

pombredanne reviewed May 20, 2022
View reviewed changes

pombredanne approved these changes May 20, 2022
View reviewed changes

TG1999 added 2 commits May 21, 2022 15:09

And gitlab importer
c32dde1
And use NginxVersion instead of SemverVersion in Nginx importer and improver Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Address review comments
5127d0b
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

TG1999 force-pushed the new_importer/gitlab branch from fb4ed56 to 260d49bCompare May 21, 2022 10:14

TG1999 linked an issue May 21, 2022 that may be closed by this pull request
Errors when running the vulnerabilities.importers.github.GitHubAPIImporter #673
Closed

TG1999 force-pushed the new_importer/gitlab branch from 260d49b to f366a01Compare May 21, 2022 10:29

Drop go support from gitlab and github
831e566
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

TG1999 force-pushed the new_importer/gitlab branch from f366a01 to 80f883aCompare May 21, 2022 10:38

Reference:aboutcode-org#673
b7ae8dc
Return PackageURL for composer in github importer if namespace is not present Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

TG1999 force-pushed the new_importer/gitlab branch from 80f883a to b7ae8dcCompare May 21, 2022 10:39

TG1999 merged commit 6ec2e9e into aboutcode-org:mainMay 21, 2022

Uh oh!

Uh oh!

Conversation

TG1999 commented Mar 31, 2022

Uh oh!

pombredanne left a comment

Choose a reason for hiding this comment

Uh oh!

TG1999 commented Apr 5, 2022

Uh oh!

pombredanne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pombredanne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pombredanne left a comment

Choose a reason for hiding this comment

Uh oh!

TG1999 commented May 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants