Skip to content

Migrate nvd importer to importer-improver model - #664

Merged
pombredanne merged 5 commits into
aboutcode-org:mainfrom
TG1999:new_importer/nvd
Apr 9, 2022
Merged

Migrate nvd importer to importer-improver model#664
pombredanne merged 5 commits into
aboutcode-org:mainfrom
TG1999:new_importer/nvd

Conversation

@TG1999

@TG1999TG1999 commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@TG1999
Migrate nvd importer to importer-improver model
3aaa7c0
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Add spdx license expression
bff3444
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@pombredannepombredanne mentioned this pull request Apr 5, 2022
Closed
@TG1999
TG1999 marked this pull request as draft April 5, 2022 19:43
@TG1999
TG1999 marked this pull request as ready for review April 6, 2022 12:53
pombredanne
pombredanne reviewed Apr 6, 2022
View reviewed changes
Comment threadvulnerabilities/importers/nvd.py
JonoYang
JonoYang reviewed Apr 7, 2022
View reviewed changes
Comment threadvulnerabilities/importers/nvd.py Outdated
JonoYang
JonoYang reviewed Apr 7, 2022
View reviewed changes

@JonoYangJonoYang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TG1999 I've looked over the code, mainly for style, but I had a question about the removal of tests from test_nvd.py

Comment threadvulnerabilities/tests/test_nvd.py
Comment threadvulnerabilities/importers/nvd.py Outdated
Comment threadvulnerabilities/importers/nvd.py Outdated
pombredanne
pombredanne requested changes Apr 8, 2022
View reviewed changes

@pombredannepombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! See some feedback for your review.

Comment threadvulnerabilities/importers/nvd.py
Comment threadvulnerabilities/importers/nvd.py
Comment threadvulnerabilities/importers/nvd.py Outdated
Comment threadvulnerabilities/importers/nvd.py
Comment threadvulnerabilities/importers/nvd.py
Comment threadvulnerabilities/importers/nvd.py Outdated
Comment threadvulnerabilities/importers/nvd.py Outdated
Comment threadvulnerabilities/importers/nvd.py
Comment threadvulnerabilities/models.py Outdated
Comment threadvulnerabilities/tests/test_cpe_reference.py
This was referenced Apr 8, 2022
Open
Open
@TG1999
Add unit tests and make model changes for storing cpe as reference_id
08beb9f
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
pombredanne
pombredanne approved these changes Apr 9, 2022
View reviewed changes

@pombredannepombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM... with a few minor nit: I would like the reference id field to be an even 200 chars and there are a few things that can refine in the future like the get_items() approach.

Comment threadvulnerabilities/importers/nvd.py
Comment threadvulnerabilities/models.py Outdated
Comment threadvulnerabilities/migrations/0007_alter_vulnerabilityreference_reference_id.py Outdated
@pombredanne
Add link to NVD License issue
c9c96c0
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Set reference_id length to 200
ec3e564
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne

pombredanne commented Apr 9, 2022

Copy link
Copy Markdown
Member

Merging now

@pombredanne
pombredanne merged commit c992168 into aboutcode-org:mainApr 9, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonoYangJonoYangJonoYang left review comments
@pombredannepombredannepombredanne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TG1999@pombredanne@JonoYang