Skip to content

Migrate redhat importer - #719

Merged
TG1999 merged 1 commit into
aboutcode-org:mainfrom
TG1999:migration/red_hat
May 13, 2022
Merged

Migrate redhat importer#719
TG1999 merged 1 commit into
aboutcode-org:mainfrom
TG1999:migration/red_hat

Conversation

@TG1999

@TG1999TG1999 commented May 3, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com

@TG1999
TG1999force-pushed the migration/red_hat branch 3 times, most recently from a73a683 to 25fbd09CompareMay 3, 2022 17:33
@TG1999TG1999 linked an issue May 3, 2022 that may be closed by this pull request
redhat importer - improver migration #718
Closed
@TG1999
TG1999force-pushed the migration/red_hat branch 2 times, most recently from 5a82321 to 5279666CompareMay 4, 2022 16:06
pombredanne
pombredanne reviewed May 4, 2022
View reviewed changes
Comment threadvulnerabilities/importers/redhat.py
pombredanne
pombredanne reviewed May 4, 2022
View reviewed changes
Comment threadvulnerabilities/importers/redhat.py
pombredanne
pombredanne reviewed May 4, 2022
View reviewed changes
Comment threadvulnerabilities/importers/redhat.py Outdated
pombredanne
pombredanne reviewed May 4, 2022
View reviewed changes
Comment threadvulnerabilities/importers/redhat.py Outdated
pombredanne
pombredanne reviewed May 4, 2022
View reviewed changes
Comment threadvulnerabilities/importers/redhat.py Outdated
pombredanne
pombredanne requested changes May 4, 2022
View reviewed changes

@pombredannepombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I posted a few review comments,
The key thing is to make sure we do not skip over data silently without logging.

@TG1999
TG1999force-pushed the migration/red_hat branch 7 times, most recently from 5bba7d7 to b6a10edCompareMay 11, 2022 12:19
pombredanne
pombredanne approved these changes May 13, 2022
View reviewed changes

@pombredannepombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... Just a few minor comments

Comment threadvulnerabilities/importers/redhat.py
Comment threadvulnerabilities/importers/redhat.py
Comment threadvulnerabilities/importers/redhat.py Outdated
@TG1999TG1999 mentioned this pull request May 13, 2022
Open
@TG1999

TG1999 commented May 13, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Thanks @pombredanne , while I was at it, I realised severities were not displayed on UI, also fixed that. Merging it as soon it's all green!
Screenshot from 2022-05-13 23-06-20

@TG1999
TG1999force-pushed the migration/red_hat branch 2 times, most recently from ae26ec3 to d3316aeCompareMay 13, 2022 17:38
@TG1999
Migrate redhat importer
4a5f320
Fix severities in UI
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
TG1999force-pushed the migration/red_hat branch from d3316ae to 4a5f320CompareMay 13, 2022 18:05
@TG1999
TG1999 merged commit 360754f into aboutcode-org:mainMay 13, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pombredannepombredannepombredanne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

redhat importer - improver migration

2 participants

@TG1999@pombredanne