Skip to content

Migrate debian importer to importer-improver model - #723

Merged
TG1999 merged 1 commit into
aboutcode-org:mainfrom
TG1999:migrate/debian
May 17, 2022
Merged

Migrate debian importer to importer-improver model#723
TG1999 merged 1 commit into
aboutcode-org:mainfrom
TG1999:migrate/debian

Conversation

@TG1999

@TG1999TG1999 commented May 4, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com

@TG1999
TG1999 marked this pull request as draft May 4, 2022 14:43
@TG1999
TG1999 marked this pull request as ready for review May 5, 2022 13:37
@TG1999
TG1999force-pushed the migrate/debian branch 5 times, most recently from 6225c34 to 23001d2CompareMay 5, 2022 17:42
@TG1999TG1999 linked an issue May 5, 2022 that may be closed by this pull request
debian_oval importer - improver migration #717
Closed
@TG1999
TG1999force-pushed the migrate/debian branch 3 times, most recently from 2b69232 to b7fc24dCompareMay 6, 2022 11:43
pombredanne
pombredanne requested changes May 10, 2022
View reviewed changes

@pombredannepombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick comments for your review!

Comment threadvulnerabilities/helpers.py Outdated
Comment threadvulnerabilities/helpers.py Outdated
Comment threadvulnerabilities/helpers.py Outdated
Comment threadvulnerabilities/importers/debian.py
@TG1999
TG1999force-pushed the migrate/debian branch 2 times, most recently from e5655dd to de0682bCompareMay 11, 2022 12:09
pombredanne
pombredanne requested changes May 13, 2022
View reviewed changes

@pombredannepombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! here are few comments for your consideration.

Comment threadvulnerabilities/helpers.py
Comment threadvulnerabilities/importers/debian.py Outdated
Comment threadvulnerabilities/importers/debian.py
Comment threadvulnerabilities/importers/debian.py
Comment threadvulnerabilities/importers/debian.py Outdated
Comment threadvulnerabilities/importers/debian.py
Comment threadvulnerabilities/importers/debian.py
Comment threadvulnerabilities/importers/debian.py Outdated
Comment threadvulnerabilities/importers/debian.py Outdated
Comment threadvulnerabilities/importers/debian.py Outdated
@TG1999
Migrate debian importer to importer-improver model
11aaf31
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999

TG1999 commented May 17, 2022

Copy link
Copy Markdown
ContributorAuthor

@pombredanne addressed all comments on this PR, please let me know if this looks good

pombredanne
pombredanne approved these changes May 17, 2022
View reviewed changes

@pombredannepombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@TG1999
TG1999 merged commit 1ed87cd into aboutcode-org:mainMay 17, 2022
@keshav-spacekeshav-space linked an issue Aug 8, 2022 that may be closed by this pull request
debian importer - improver migration #716
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pombredannepombredannepombredanne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

debian_oval importer - improver migration debian importer - improver migration

2 participants

@TG1999@pombredanne