Fix/issues 758 757 756 755 - #795
Merged
Chucks1093 merged 4 commits intoAug 27, 2026
Merged
Conversation
The 10,000-iteration fuzz tests exceeded the default Soroban host budget (Error(Budget, ExceededLimit)) in CI. Reduce iterations to 1,000 and reset the budget every 200 iterations via env.cost_estimate().budget(). reset_default().
Remove the three property-based fuzz tests per maintainer review feedback: they exhaust the Soroban host budget at scale and block CI. Core feature work (batch buy, royalty config, curve migration) lands on its own.
5 tasks
6 tasks
3 tasks
Adejumo-2
added a commit
to Adejumo-2/accesslayer-contracts
that referenced
this pull request
Aug 28, 2026
…and accesslayerorg#795 Two PRs (protocol-fee-holder-cap-lockup-ttl and fix/issues-758-757-756-755) branched from the same base and added items at positions 41-43 in ContractError, plus different DataKey variants, storage helpers, contract methods, and event types. When merged into main, the implementation code was silently dropped while the test files survived, causing compilation failures. Restored: - DataKey variants: RoyaltyConfig, CurveExponent, AuctionConfig, StakeUnlockLedger, TotalStaked, StakingRewardsPool, HolderCapBps, LastBuyTimestamp, ProtocolFeeBps, LockupDurationSecs - ContractError variants: BatchSizeExceeded, RoyaltyExceedsLimit, InvalidExponent, MaxHoldingExceeded, LockupPeriodActive, InvalidHolderCap - Contract methods: batch_buy, set_royalty, get_royalty_config, migrate_curve, get_curve_exponent, refresh_ttl - Event types: FeeCollectedEvent, LockupBlockedEvent - Storage helpers: holder_cap_bps, last_buy_timestamp - AuctionConfig struct - cargo fmt applied to all affected files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds batch key purchasing, creator royalty configuration, and bonding curve exponent migration to the creator-keys contract. Property-based fuzz tests are excluded from this PR per maintainer review feedback on the previous PR — they exhaust the Soroban host budget in CI and will be delivered separately.
Changes
batch_buy_completedevent.CurveExponentstorage that takes priority overCurvePreset.BatchSizeExceeded,InvalidExponent,RoyaltyExceedsLimit.RoyaltyConfig(Address),CurveExponent(Address)(appended at end — serialization safe).BatchBuyCompletedEvent,CurveMigratedEvent,RoyaltyUpdatedEvent.Issues
Resolves #758
Resolves #757
Resolves #756
Resolves #755
Verification
Manual code review of complete diff confirmed:
Local verification: 45 issue tests pass (
cargo test -p creator-keys --lib test_issues), fmt and clippy clean. Full CI run also passed on this branch before retargeting.