fix: resolve CI build errors (config schema duplicate, UNPROCESSABLE_ENTITY, keyId param) - #856
Open
yugomania wants to merge 2 commits into
Open
fix: resolve CI build errors (config schema duplicate, UNPROCESSABLE_ENTITY, keyId param)#856yugomania wants to merge 2 commits into
yugomania wants to merge 2 commits into
Conversation
Remove duplicate STELLAR_AUTH_SECRET from config schema, add the missing UNPROCESSABLE_ENTITY error code, and normalize the creator route keyId param so Prisma receives a string. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Member
✅ CI Passed —
|
Resolve conflict by taking upstream's already-merged versions of config.schema.ts and creator.routes.ts; the PR's fixes are already in main. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #769
Summary
Fixes three pre-existing TypeScript build errors on
mainthat breakpnpm build:src/config.schema.ts—STELLAR_AUTH_SECRETwas declared twice (duplicate object property,TS1117). Removed the redundant trailing declaration; the canonical definition with its SEP-10 challenge-signing comment is kept.src/constants/error.constants.ts— routes inadmin.routes.tsandcreator.routes.tsreferenceErrorCode.UNPROCESSABLE_ENTITY(HTTP 422) but the constant was never defined (TS2339). Added it, following the existingErrorCodeconvention.src/modules/creator/creator.routes.ts—req.params.keyIdis typedstring | string[]under Express 5; normalized withString(...)(same pattern already used throughoutadmin.routes.ts) so Prisma receives astringfilter (TS2322).Why this is a separate PR
These are base-
mainissues unrelated to any feature work. Keeping them isolated lets the token-expiry PR stay narrowly scoped.Validation
pnpm buildpasses (exit 0, zero TS errors)pnpm lintpasses