fix: prevent exitChan blocking in websocket mode - #399
Merged
Conversation
aceld
commented
Apr 28, 2026
Owner
@chenhang233 感谢提交PR,虽然这个改动不大,但是很关键,这个问题我没复现出来,请问你是否有复现的步骤,来确保你这边修复的正确性。 |
chenhang233
commented
Apr 28, 2026
Author
chenhang233
commented
Apr 28, 2026
via email
Author
我在GitHub上面回复了复现案例,请看看 …---Original---
From: ***@***.***>
Date: Tue, Apr 28, 2026 14:32 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [aceld/zinx] fix: prevent exitChan blocking in websocket mode (PR #399)
aceld left a comment (aceld/zinx#399)
@chenhang233 感谢提交PR,虽然这个改动不大,但是很关键,这个问题我没复现出来,请问你是否有复现的步骤,来确保你这边修复的正确性。
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: ***@***.***> |
aceld
commented
May 4, 2026
Owner
@chenhang233 |
aceld
commented
May 4, 2026
Owner
先优先合并此PR。 |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

通过退出信号试图停止进程,发现一直阻塞到超时.
关闭的 channel 会立即让所有阻塞的 <-ch 操作返回零值. t.exitChan <- struct{}{} 是多余的.
如果只启动websocket模式:
没有 goroutine 在执行 <-s.exitChan
s.exitChan <- struct{}{} 永久阻塞