refactor(bench): consolidate setup abort handling - #180
Conversation
- Share `OrAbort` across exact and comparison benchmarks while preserving contextual panic behavior. - Centralize Clippy policy in Cargo.toml for consistent local and CI checks. - Keep `unreachable_pub` enforced while allowing intentional crate-visible helpers. - Enable CodeRabbit's request-changes review workflow. Closes#165
📝 WalkthroughWalkthroughChangesThe benchmark suite now shares an Benchmark abort handling
Lint and review configuration
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #180 +/- ##
=======================================
Coverage 97.75% 97.75% =======================================
Files 8 8 Lines 4624 4624 =======================================
Hits 4520 4520 Misses 104 104
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@justfile`:
- Around line 352-361: Update the clippy-all-targets and clippy-exact recipes to
pass -D warnings to cargo clippy, ensuring every configured Clippy invocation
fails on warnings while preserving the existing workspace, feature, and target
arguments.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b2fc8cab-7e0e-476b-9572-b0a83deecf63
📒 Files selected for processing (12)
.coderabbit.yaml.github/workflows/rust-clippy.ymlAGENTS.mdCargo.tomlbenches/common/bench_utils.rsbenches/common/exact.rsbenches/exact.rsbenches/vs_linalg.rsclippy.tomljustfilesrc/scaled_product.rstests/exact_bench_config.rs
💤 Files with no reviewable changes (1)
- src/scaled_product.rs
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
OrAbortacross exact and comparison benchmarks while preserving contextual panic behavior.unreachable_pubenforced while allowing intentional crate-visible helpers.Closes#165
Summary by CodeRabbit
Developer Experience
Testing