Uh oh!
There was an error while loading. Please reload this page.
CLI-1860: Updated response to include download links. - #2028
CLI-1860: Updated response to include download links.#2028vishalkhode1 wants to merge 2 commits into
Conversation
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/2028/acli.phar |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #2028 +/- ##
=========================================
Coverage 92.49% 92.50% - Complexity 1995 2000 +5
=========================================
Files 123 123 Lines 7238 7246 +8 =========================================
+ Hits 6695 6703 +8
Misses 543 543 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
deepakmishra2
left a comment
There was a problem hiding this comment.
We should also add test for api:site-instances:database:backups with a _links.download fixture and asserts the download URL is preserved.
| $this->assertArrayNotHasKey('_links', $decoded[0]); | ||
| $this->assertArrayNotHasKey('_links', $decoded[1]); | ||
| $this->assertArrayHasKey('_links', $decoded[0]); | ||
| $this->assertEmpty($decoded[0]['_links']); |
There was a problem hiding this comment.
and once we have the test we can change this assertion to assertArrayNotHasKey('_links', ...) for fixtures without a download key
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the |
No description provided.