Skip to content

Fetch only required remotes. Saves disk space and bandwidth by default. - #6

Merged
lmignon merged 3 commits into
acsone:masterfrom
Tecnativa:master-fetch-only-required
Jan 3, 2017
Merged

lmignon merged 3 commits into
acsone:masterfrom
Tecnativa:master-fetch-only-required

Conversation

@yajo

@yajo yajo commented Jan 2, 2017

Copy link
Copy Markdown
Contributor

With this simple patch, we will save lots of time, disk space and bandwidth by default, by only fetching required remotes. In projects like Odoo, this means saving thousands of commits between versions.

@Tecnativa

@coveralls

coveralls commented Jan 2, 2017

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) to 88.129% when pulling 6e49d47 on Tecnativa:master-fetch-only-required into d2782cf on acsone:master.

@lmignon

lmignon commented Jan 2, 2017

Copy link
Copy Markdown
Member

@yajo Thank you for this nice contrib. Can you update the README.rst file to describe this new parameter and also to adapt the examples? Indeed with this change the example with the merge of a specific commit is not right...

@coveralls

coveralls commented Jan 2, 2017

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.2%) to 87.943% when pulling 3e18c61 on Tecnativa:master-fetch-only-required into d2782cf on acsone:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.9%) to 87.234% when pulling 2d4ac4d on Tecnativa:master-fetch-only-required into d2782cf on acsone:master.

@coveralls

coveralls commented Jan 2, 2017

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.9%) to 89.007% when pulling 797aad1 on Tecnativa:master-fetch-only-required into d2782cf on acsone:master.

2 similar comments
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.9%) to 89.007% when pulling 797aad1 on Tecnativa:master-fetch-only-required into d2782cf on acsone:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.9%) to 89.007% when pulling 797aad1 on Tecnativa:master-fetch-only-required into d2782cf on acsone:master.

@yajo

yajo commented Jan 2, 2017

Copy link
Copy Markdown
Contributor Author

@lmignon Thanks for your interest and patience, this should be ready to merge now. You have new tests, all checks are ✔️.

However I think you should raise the version when pushing this to pypi. This change can introduce an incompatibility in some specific scenarios, where they would still be working if they froze their requirements.

@lmignon

lmignon commented Jan 2, 2017

Copy link
Copy Markdown
Member

@yajo Thank you to you for the contribution!

However I think you should raise the version when pushing this to pypi. This change can introduce an incompatibility in some specific scenarios, where they would still be working if they froze their requirements.

The version on pypi is 1.0.0 and the first change done after the first release has been to bump the version to 1.0.1.dev0 😏 faafa0d
The version will be bumped again before the release... may be 2.0.0...

@lmignon
lmignon requested a review from sbidoul January 2, 2017 13:16
Comment thread git_aggregator/repo.py Outdated
_git_version = None

def __init__(self, cwd, remotes, merges, target,
def __init__(self, cwd, remotes, merges, target, fetch_all=False,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To preserve backward compatibility it's better to add new optional parameters at the end.

@sbidoul sbidoul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yajo thanks for this contrib. Just one minor remark regarding the new constructor parameter, otherwise looks good to me.

@yajo

yajo commented Jan 3, 2017

Copy link
Copy Markdown
Contributor Author

Fixed! 😊

@coveralls

coveralls commented Jan 3, 2017

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.9%) to 89.007% when pulling af14fb6 on Tecnativa:master-fetch-only-required into d2782cf on acsone:master.

- Unify tabs and spaces.
- Delete remainders of Markdown markup.
- Correct indentation for all blocks.
- Separate configuration from usage instructions.
- Add sections where needed.
@yajo

yajo commented Jan 3, 2017

Copy link
Copy Markdown
Contributor Author

I was preparing another PR and found it out very hard to document because currently README is a little messy, so I took the chance and fixed it here too. I hope you don't mind. This should be ready now.

@coveralls

coveralls commented Jan 3, 2017

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.9%) to 89.007% when pulling 23c5647 on Tecnativa:master-fetch-only-required into d2782cf on acsone:master.

2 similar comments
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.9%) to 89.007% when pulling 23c5647 on Tecnativa:master-fetch-only-required into d2782cf on acsone:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.9%) to 89.007% when pulling 23c5647 on Tecnativa:master-fetch-only-required into d2782cf on acsone:master.

@lmignon

lmignon commented Jan 3, 2017

Copy link
Copy Markdown
Member

@yajo

I hope you don't mind.

For sure no!

@sbidoul sbidoul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lmignon
lmignon merged commit 115f7e9 into acsone:master Jan 3, 2017
@yajo yajo mentioned this pull request Jan 3, 2017
1 task
@yajo
yajo deleted the master-fetch-only-required branch January 3, 2017 11:58
yajo added a commit to Tecnativa/doodba that referenced this pull request Jan 24, 2017
Now acsone/git-aggregator#6 and acsone/git-aggregator#7 are merged.

However, we still have to use a development version, so we hash-pin it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants