Skip to content

add launcher config - #234

Draft
fesily wants to merge 67 commits into
actboy168:masterfrom
fesily:launcher-config
Draft

add launcher config#234
fesily wants to merge 67 commits into
actboy168:masterfrom
fesily:launcher-config

Conversation

@fesily

@fesilyfesily commented Mar 17, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

signature两个配置module和version,module需要用户填写,version自动从luaVersion字段读取

将attach的luaversion默认设置为unknown,允许launcher自动判断版本

将luadbug和launcher添加为module黑名单
将调试器目录下的所有module为黑名单

@actboy168

actboy168 commented Mar 17, 2023

Copy link
Copy Markdown
Owner

package_json.lua的格式全乱了

actboy168
actboy168 requested changes Mar 17, 2023
View reviewed changes
Comment threadextension/js/configurationProvider.js Outdated
Comment threadextension/script/frontend/proxy.lua Outdated
@actboy168

actboy168 commented Mar 17, 2023

Copy link
Copy Markdown
Owner

由launcher加载调试器dll的代码也可以包含进来，这很有用。

@fesily

fesily commented Mar 18, 2023

Copy link
Copy Markdown
ContributorAuthor

package_json.lua的格式全乱了

设置中保存自动format,我先添加一个pull来完成code-format的功能把现有的lua文件都format一遍

@actboy168

actboy168 commented Mar 18, 2023

Copy link
Copy Markdown
Owner

format是个大工程，尤其是在lua 的format还不是很成熟的情况下。所以你还是先别改吧。

@fesily

fesily commented Mar 18, 2023

Copy link
Copy Markdown
ContributorAuthor

format是个大工程，尤其是在lua 的format还不是很成熟的情况下。所以你还是先别改吧。

嗯,就先启用设置,保证以后format的结果

@fesily

fesily commented Mar 18, 2023

Copy link
Copy Markdown
ContributorAuthor

把我搞懵了,package_json.lua文件用的是windows的换行符号,怪不得一format整个文件变了,你是如何打算的,统一使用哪种?

@fesily

fesily commented Mar 18, 2023

Copy link
Copy Markdown
ContributorAuthor

由launcher加载调试器dll的代码也可以包含进来，这很有用。

单纯加载调试器?还是要把导入表修复的部分也加入?

@actboy168

actboy168 commented Mar 18, 2023

Copy link
Copy Markdown
Owner

只加载就好

@actboy168

actboy168 commented Mar 18, 2023•
edited
Loading

Copy link
Copy Markdown
Owner

把我搞懵了,package_json.lua文件用的是windows的换行符号,怪不得一format整个文件变了,你是如何打算的,统一使用哪种?

用lf吧，我记得我的git配置是会强制转为lf的

@fesily

fesily commented Mar 18, 2023

Copy link
Copy Markdown
ContributorAuthor

把我搞懵了,package_json.lua文件用的是windows的换行符号,怪不得一format整个文件变了,你是如何打算的,统一使用哪种?

用lf吧，我记得我的git配置是会强制转为lf的

主干上直接format成lf吧,pull里就不做这个操作了

@fesily
fesily marked this pull request as ready for review April 6, 2023 07:05
@fesily
fesily requested a review from actboy168April 6, 2023 07:17
actboy168
actboy168 requested changes Apr 6, 2023
View reviewed changes
Comment threadsrc/launcher/autoattach/lua_version.cpp
Comment threadextension/script/debugger.lua Outdated
Comment threadsrc/launcher/config/config.cpp Outdated
Comment threadsrc/launcher/main.cpp Outdated
actboy168
actboy168 requested changes Apr 6, 2023
View reviewed changes
Comment threadsrc/launcher/autoattach/lua_module.cpp Outdated
actboy168
actboy168 requested changes Apr 6, 2023
View reviewed changes
Comment threadsrc/launcher/main.cpp Outdated
fesily
fesily commented Apr 7, 2023
View reviewed changes
Comment threadextension/script/attach.lua
@fesily
fesily requested a review from actboy168April 7, 2023 05:11
actboy168
actboy168 requested changes Apr 7, 2023
View reviewed changes
Comment threadextension/script/debugger.lua Outdated
@fesily
fesily requested a review from actboy168April 7, 2023 07:07
@fesily

fesily commented Apr 21, 2023

Copy link
Copy Markdown
ContributorAuthor

最近在忙其他的,review咋样,还有需要哪里改进的吗 @actboy168

@actboy168

actboy168 commented Apr 22, 2023

Copy link
Copy Markdown
Owner

我最近也挺忙的，所以还没空review

@fesily

fesily commented Apr 22, 2023

Copy link
Copy Markdown
ContributorAuthor

我最近也挺忙的，所以还没空review

好的,等你忙完

@fesily
fesily marked this pull request as draft July 2, 2026 09:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@actboy168actboy168Awaiting requested review from actboy168

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fesily@actboy168