Shutdown the scaleset when runner is deprecated

[nikola-jokic]

The runner PR exiting with exit code 7 when ACTIONS_RUNNER_RETURN_VERSION_DEPRECATED_EXIT_CODE=1: actions/runner#4285

This should propagate stops to the scaleset and set it to outdated, cleaning up resources.

[github-actions]

Hello! Thank you for your contribution.

Please review our contribution guidelines to understand the project's testing and code conventions.

[Copilot]

Pull request overview

This PR adds “runner deprecation” handling so that when the runner exits with the version-deprecated signal (exit code 7, enabled via ACTIONS_RUNNER_RETURN_VERSION_DEPRECATED_EXIT_CODE=1), the controller marks the involved resources as Outdated and begins tearing down the scale set resources to clean up.

Changes:

• Inject ACTIONS_RUNNER_RETURN_VERSION_DEPRECATED_EXIT_CODE=1 into ephemeral runner pods and treat runner exit code 7 as “Outdated”.
• Introduce Phase fields and enums for EphemeralRunner, EphemeralRunnerSet, and AutoscalingRunnerSet, and propagate “Outdated” from runner → runnerset → autoscaling runnerset cleanup.
• Update controllers/tests/CRDs to use the new status field names (RunnerID, WorkflowRunID, etc.) and new phase types.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
controllers/actions.github.com/resourcebuilder.go	Adds deprecated-exit-code env var to ephemeral runner container.
controllers/actions.github.com/constants.go	Introduces env var constant for deprecated version exit-code behavior.
controllers/actions.github.com/ephemeralrunner_controller.go	Detects exit code 7, marks EphemeralRunner as Outdated, and removes it from the service.
controllers/actions.github.com/ephemeralrunner_controller_test.go	Updates tests to use EphemeralRunnerPhase and renamed status fields.
controllers/actions.github.com/ephemeralrunnerset_controller.go	Tracks Outdated runners, adds runnerset phase, and short-circuits reconciliation when Outdated.
controllers/actions.github.com/ephemeralrunnerset_controller_test.go	Updates tests for renamed status fields and new phase types/values.
controllers/actions.github.com/autoscalingrunnerset_controller.go	Detects outdated runnerset and triggers full scale set cleanup; adds change-hash annotation.
controllers/actions.github.com/autoscalingrunnerset_controller_test.go	Updates expected status to use Phase instead of State and formatting changes.
cmd/ghalistener/scaler/scaler.go	Updates patched EphemeralRunner status field names (JobRequestID, WorkflowRunID).
apis/actions.github.com/v1alpha1/ephemeralrunner_types.go	Renames status fields (e.g., RunnerID) and introduces EphemeralRunnerPhase including Outdated.
apis/actions.github.com/v1alpha1/ephemeralrunnerset_types.go	Adds EphemeralRunnerSetStatus.Phase and phase enum (Running/Outdated).
apis/actions.github.com/v1alpha1/autoscalingrunnerset_types.go	Replaces status State with Phase, adds phase enum, and adds Hash() helper.
config/crd/bases/actions.github.com_ephemeralrunnersets.yaml	Adds .status.phase to the EphemeralRunnerSet CRD schema.
config/crd/bases/actions.github.com_autoscalingrunnersets.yaml	Replaces .status.state with .status.phase in the AutoscalingRunnerSet CRD schema.
charts/gha-runner-scale-set-controller/crds/actions.github.com_ephemeralrunnersets.yaml	Mirrors EphemeralRunnerSet CRD schema update for Helm chart.
charts/gha-runner-scale-set-controller/crds/actions.github.com_autoscalingrunnersets.yaml	Mirrors AutoscalingRunnerSet CRD schema update for Helm chart.
charts/gha-runner-scale-set-controller-experimental/crds/actions.github.com_ephemeralrunnersets.yaml	Mirrors EphemeralRunnerSet CRD schema update for experimental chart.
charts/gha-runner-scale-set-controller-experimental/crds/actions.github.com_autoscalingrunnersets.yaml	Mirrors AutoscalingRunnerSet CRD schema update for experimental chart.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.