Skip to content

feat: permissions - #168

Merged
parkerbxyz merged 13 commits into
mainfrom
permissions_inputs
Mar 27, 2025
Merged

feat: permissions#168
parkerbxyz merged 13 commits into
mainfrom
permissions_inputs

Conversation

@gr2m

@gr2mgr2m commented Sep 5, 2024

Copy link
Copy Markdown
Contributor

closes#3

  • Load app-permissions from schema exported by @octokit/openapi
  • Update documentation in README.md
  • Implement the permissions_* inputs in the action code

could be done as follow ups:

@gr2m
gr2mforce-pushed the permissions_inputs branch from 2804fe1 to 580a7f4CompareSeptember 5, 2024 23:09
@gr2mgr2m mentioned this pull request Sep 13, 2024
@gr2mgr2m mentioned this pull request Oct 7, 2024
@gr2m

gr2m commented Feb 7, 2025

Copy link
Copy Markdown
ContributorAuthor

We ran into a few blockers trying to fix the update automation for https://github.com/octokit/app-permissions, see octokit/app-permissions#262

For now, we will just update the action.yml manually and implement the feature, and postpone all the automation

@gr2m

gr2m commented Mar 13, 2025

Copy link
Copy Markdown
ContributorAuthor

We finally had a time to catch up and assess where we stand. We will now

  • add https://github.com/octokit/openapi as dev dependency
  • Create a cache file (e.g. build/app-permissions.json) in this repository which will only contain the schema for "app-permissions" for easier debugging
  • Use thebuild/app-permissions.json file in this repository as source to generated / update the action.yml file

@gr2m
gr2mforce-pushed the permissions_inputs branch from 2baee4e to 766bb55CompareMarch 13, 2025 20:02
@gr2mgr2m changed the title WIP script to update action.yml with permissions based on https://github.com/octokit/app-permissions/blob/main/generated/api.github.com.jsonbuild(script): update permission-* inputs in action.yml based on @octokit/openapiMar 13, 2025
@parkerbxyzparkerbxyz added this to the v2 milestone Mar 20, 2025
Comment threadCONTRIBUTING.md
@gr2m
gr2m marked this pull request as ready for review March 25, 2025 19:09
@gr2m
gr2m requested a review from a team as a code ownerMarch 25, 2025 19:09
@gr2mgr2m changed the title build(script): update permission-* inputs in action.yml based on @octokit/openapifeat: permissionsMar 25, 2025
Comment threadmain.js

@parkerbxyzparkerbxyz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@parkerbxyz
parkerbxyz enabled auto-merge (squash) March 27, 2025 18:59
@parkerbxyz
parkerbxyz merged commit 0e0aa99 into mainMar 27, 2025
@parkerbxyz
parkerbxyz deleted the permissions_inputs branch March 27, 2025 19:00
create-app-token-action-releaserBot pushed a commit that referenced this pull request Mar 27, 2025
# [1.12.0](v1.11.7...v1.12.0) (2025-03-27)
### Features
* permissions ([#168](#168)) ([0e0aa99](0e0aa99))
@create-app-token-action-releaser

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Yang-33Yang-33 mentioned this pull request Mar 28, 2025
@coderabbitaicoderabbitaiBot mentioned this pull request Jun 20, 2026
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support custom permissions

2 participants

@gr2m@parkerbxyz