Skip to content

Bumping actions/core and actions/github dependencies for GHES - #69

Merged
pjquirk merged 6 commits into
actions:masterfrom
pjquirk:users/paquirk/ghesfixes
May 12, 2020
Merged

Bumping actions/core and actions/github dependencies for GHES#69
pjquirk merged 6 commits into
actions:masterfrom
pjquirk:users/paquirk/ghesfixes

Conversation

@pjquirk

@pjquirkpjquirk commented May 8, 2020

Copy link
Copy Markdown
Contributor

This adds support for running against GHES by using v2.2.0 of @actions/github. I also bumped @actions/core to 1.2.4 to fix error handling in the case an Error type is thrown rather than a string.

The build/pack steps seemed unreliable, so I updated the Typscript config to build to ./lib, and ncc will then build out of that (this matches other actions like actions/stale).

Tested by pushing this version of the action to an "actions" org on the GHES instance. I also needed to set NODE_TLS_REJECT_UNAUTHORIZED = 0 temporarily in the action to get around my self-signed (or otherwise not trusted) server cert.

@pjquirkpjquirk changed the title Bumping actions/github to 2.2.0Bumping actions/core and actions/github dependencies for GHESMay 12, 2020
@pjquirk
pjquirk requested review from dakale and ericscipleMay 12, 2020 18:43
Comment threadlib/main.js Outdated
@dakale

Copy link
Copy Markdown
Contributor

What is the benefit of changing from dist/index to lib/index? Not sure I understand the point, or why the lib/ file is so much smaller than the dist/ one...

@pjquirk

Copy link
Copy Markdown
ContributorAuthor

@dakale It's mainly to distinguish the outputs of tsc (lib) and the outputs of ncc (dist). It doesn't make sense to put them both into the same folder, like it was before. dist should have one file in it, index.js.

@dakale

Copy link
Copy Markdown
Contributor

Thanks, that makes sense, as does ignoring checking in lib/

@dakale

dakale commented May 12, 2020

Copy link
Copy Markdown
Contributor

(I can merge if you dont have permission)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pjquirk@dakale@ericsciple