Skip to content

Don't try to download windows exe/msi and mac universal pkg if it doesn't exists for python version requested - #276

Open
jmarrec wants to merge 2 commits into
actions:mainfrom
jmarrec:windows_pkg_exists
Open

Don't try to download windows exe/msi and mac universal pkg if it doesn't exists for python version requested#276
jmarrec wants to merge 2 commits into
actions:mainfrom
jmarrec:windows_pkg_exists

Conversation

@jmarrec

Copy link
Copy Markdown

Only some minor versions of python have an actual windows .exe / .msi installer.

eg:

@jmarrec
jmarrec requested a review from a team as a code ownerMay 29, 2024 05:30
@jmarrecjmarrec changed the title Don't try to continue for windows if download link for exe/msi doesn't exists for python version requestedDon't try to download windows exe/msi and mac universal pkg if it doesn't exists for python version requestedMay 29, 2024
@mayeut

mayeut commented Jun 1, 2024

Copy link
Copy Markdown
Contributor

Rather than silently ignore some network failures that would lead to the version being skipped, the json returned by https://www.python.org/api/v2/downloads/release/?is_published=true/https://www.python.org/api/v2/downloads/release_file/?release=... should be parsed to check if the package exists or not. This shall probably be done while generating the build matrix.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jmarrec@mayeut