Uh oh!
There was an error while loading. Please reload this page.
Do not give up if Results is powering logs - #2893
Merged
Merged
Conversation
yacaovsnc
marked this pull request as ready for review
September 27, 2023 14:42
pje
commented
Sep 28, 2023
Contributor
The logical change makes sense to me! One request: if we're renaming variables, can we do it everywhere all at once? 👉 https://github.com/search?q=repo%3Ayacaovsnc%2Frunner%20resultServiceOnly&type=code |
yacaovsnc
commented
Sep 28, 2023
ContributorAuthor
Thanks @pje! I think I got all the name variables. Grep doesn't show any more instance of the old |
pje
commented
Sep 28, 2023
Contributor
@yacaovsnc Yep, you're right! I messed up the new search syntax and was looking at the main branch. 🤦 Looks good! 👍 |
pje
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not give up if Results is powering logs. Continue to upload the next file in that case.