Skip to content

Update setup job starting logs - #4383

Merged
TingluoHuang merged 9 commits into
actions:mainfrom
GitPaulo:gitpaulo/update-setup-job-logs
May 4, 2026
Merged

Update setup job starting logs#4383
TingluoHuang merged 9 commits into
actions:mainfrom
GitPaulo:gitpaulo/update-setup-job-logs

Conversation

@GitPaulo

@GitPauloGitPaulo commented Apr 28, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Overview

We are cleaning up setup job logs and this is a first step to restore parity to LHR logs and improve on it further in the future.

Issue: https://github.com/github/hosted-compute/issues/3955

CopilotAI review requested due to automatic review settings April 28, 2026 11:04
@GitPaulo
GitPaulo requested a review from a team as a code ownerApril 28, 2026 11:04
@GitPaulo
gate both runner name and group name
07e0a31
Co-authored-by: Copilot <copilot@github.com>
CopilotAI reviewed Apr 28, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the “Set up job” startup logging in JobExtension.InitializeJob to better align runner identification details (runner name, runner group) with the desired LHR/self-hosted log output.

Changes:

  • Log runner name unconditionally from runner settings.
  • Log runner group name based on configured pool metadata (PoolId / PoolName).
  • Keep machine name logging gated on detecting OAuth-based credentials.
Show a summary per file
FileDescription
src/Runner.Worker/JobExtension.csAdjusts setup-job log lines for runner identity/group details.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 3

Comment threadsrc/Runner.Worker/JobExtension.cs Outdated
Comment threadsrc/Runner.Worker/JobExtension.cs Outdated
Comment threadsrc/Runner.Worker/JobExtension.cs Outdated
GitPaulo
GitPaulo commented Apr 28, 2026
View reviewed changes
Comment threadsrc/Runner.Worker/JobExtension.cs Outdated
GitPauloand others added 2 commits April 28, 2026 12:15
TingluoHuang
TingluoHuang reviewed Apr 28, 2026
View reviewed changes
Comment threadsrc/Runner.Worker/JobExtension.cs Outdated
TingluoHuang
TingluoHuang reviewed Apr 28, 2026
View reviewed changes
Comment threadsrc/Runner.Worker/JobExtension.cs Outdated
@GitPaulo

GitPaulo commented Apr 28, 2026

Copy link
Copy Markdown
ContributorAuthor

Note: L0 tests are flaky, I can't re-run them as I'm committing from a fork. It should be 🆗 to ignore.

@GitPaulo
GitPaulo requested a review from TingluoHuangMay 4, 2026 10:20
@TingluoHuang
TingluoHuang merged commit 16c8a91 into actions:mainMay 4, 2026
11 checks passed
github-actionsBot pushed a commit to johngeorgewright/actions-runner that referenced this pull request May 11, 2026
@GitPaulo@github-actions
Update setup job starting logs (actions#4383)
94a8e8f
gordolara789-tech
gordolara789-tech reviewed May 13, 2026
View reviewed changes

@gordolara789-techgordolara789-tech left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exito

@github-actionsgithub-actionsBot mentioned this pull request Jul 1, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@TingluoHuangTingluoHuangTingluoHuang approved these changes
+1 more reviewer
@gordolara789-techgordolara789-techgordolara789-tech left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GitPaulo@TingluoHuang@gordolara789-tech