Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 1.4k
Send welcome message in debugger console on connect#4419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
45aea30
Add DebuggerWelcomeMessage to job message and config
rentziass 6f69411
Send welcome message on debugger configurationDone
rentziass ff6d568
Add tests for debugger welcome message
rentziass a57b69e
Reset welcome message flag on client reconnect
rentziass d4d6c3e
Use override flag variable for debugger welcome message
rentziass d4b902b
Update debugger welcome message tests for override flag
rentziass 1116c20
Clarify DebuggerWelcomeMessage doc comment
rentziass 8a87493
Merge branch 'main' into rentziass/debugger-welcome-message
rentziass File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -267,6 +267,21 @@ public DebuggerTunnelInfo DebuggerTunnel | ||
| set; | ||
| } | ||
| /// <summary> | ||
rentziass marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| /// Optional welcome message shown in the debugger console when a client connects. | ||
| /// Only used when the <c>actions_runner_override_debugger_welcome_message</c> | ||
| /// feature flag is set to <c>true</c> in the job variables. With the flag set, | ||
| /// a non-empty value is shown as-is and a null or empty value suppresses the | ||
| /// default welcome message. When the flag is not set, the runner shows its | ||
| /// built-in help text and this field is ignored. | ||
| /// </summary> | ||
| [DataMember(EmitDefaultValue = false)] | ||
| public string DebuggerWelcomeMessage | ||
| { | ||
| get; | ||
| set; | ||
| } | ||
| /// <summary> | ||
| /// Gets the workflow-level action dependencies (lockfile entries) | ||
| /// </summary> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.